Skip to content

Fix NodeGetVolumeStats to conform to CSI 1.6 Spec#425

Merged
AkshaySainiDell merged 3 commits into
mainfrom
fix-node-get-volume-stat
Jul 25, 2025
Merged

Fix NodeGetVolumeStats to conform to CSI 1.6 Spec#425
AkshaySainiDell merged 3 commits into
mainfrom
fix-node-get-volume-stat

Conversation

@AkshaySainiDell

@AkshaySainiDell AkshaySainiDell commented Jul 24, 2025 •
edited by suryagupta4
Loading

Copy link
Copy Markdown
Contributor

Description

Fix NodeGetVolumeStats to conform to CSI 1.6 Spec.

  • Node Service should work
  • Node Service should be idempotent

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1896

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

@github-actions

github-actions Bot commented Jul 25, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerscale/service 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerscale/service/controller.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/service/isiService.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/service/node.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/service/replication.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/service/service.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerscale/service/node_test.go

@AkshaySainiDell AkshaySainiDell marked this pull request as ready for review July 25, 2025 05:29
HarishH-DELL
HarishH-DELL approved these changes Jul 25, 2025
View reviewed changes

@HarishH-DELL HarishH-DELL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkshaySainiDell AkshaySainiDell merged commit 82d05f7 into main Jul 25, 2025
6 checks passed
@AkshaySainiDell AkshaySainiDell deleted the fix-node-get-volume-stat branch July 25, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atye atye Awaiting requested review from atye

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@chimanjain chimanjain Awaiting requested review from chimanjain

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@donatwork donatwork Awaiting requested review from donatwork

@meggm meggm Awaiting requested review from meggm

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

3 more reviewers

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@HarishH-DELL HarishH-DELL HarishH-DELL approved these changes

@rishabhatdell rishabhatdell rishabhatdell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AkshaySainiDell @suryagupta4 @HarishH-DELL @rishabhatdell