Skip to content

Add ListSnapshot to conform to CSI 1.6 Spec#424

Merged
AkshaySainiDell merged 3 commits into
mainfrom
list_snap_csi_spec_changes
Jul 22, 2025
Merged

Add ListSnapshot to conform to CSI 1.6 Spec#424
AkshaySainiDell merged 3 commits into
mainfrom
list_snap_csi_spec_changes

Conversation

@AkshaySainiDell

@AkshaySainiDell AkshaySainiDell commented Jul 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR addresses the following CSI Spec 1.6 test scenarios for ListSnapshot

  • Should return snapshots matching snapshot ID
  • Should return empty for non-existent snapshot ID
  • Should return snapshots matching source volume ID
  • Should return empty for non-existent source volume ID
  • Should check presence of new snapshots
  • Should return next token for limited entries
  • Should return appropriate values

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1896

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Successfully executed k8s e2e
  • Sanity tests for ListSnapshotimage

@AkshaySainiDell AkshaySainiDell marked this pull request as ready for review July 22, 2025 09:21
@AkshaySainiDell AkshaySainiDell force-pushed the list_snap_csi_spec_changes branch from 54c86e5 to f66d498 Compare July 22, 2025 09:33
rishabhatdell
rishabhatdell previously approved these changes Jul 22, 2025
View reviewed changes
bpjain2004
bpjain2004 reviewed Jul 22, 2025
View reviewed changes
Comment thread service/controller.go Outdated
Comment thread service/controller.go
Comment thread service/controller.go
Comment thread service/controller.go
Comment thread service/controller_test.go
Comment thread service/controller.go
suryagupta4
suryagupta4 previously approved these changes Jul 22, 2025
View reviewed changes
karthikk92
karthikk92 previously approved these changes Jul 22, 2025
View reviewed changes
donatwork
donatwork previously approved these changes Jul 22, 2025
View reviewed changes
Comment thread service/controller.go Outdated
Comment thread service/step_defs_test.go
meggm
meggm previously approved these changes Jul 22, 2025
View reviewed changes
nitesh3108
nitesh3108 previously approved these changes Jul 22, 2025
View reviewed changes
HarishH-DELL
HarishH-DELL previously approved these changes Jul 22, 2025
View reviewed changes
@github-actions

github-actions Bot commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerscale/service 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerscale/service/controller.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/service/isiService.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerscale/service/controller_test.go
  • github.com/dell/csi-powerscale/service/step_defs_test.go

@AkshaySainiDell AkshaySainiDell merged commit 77ef84c into main Jul 22, 2025
11 of 12 checks passed
@AkshaySainiDell AkshaySainiDell deleted the list_snap_csi_spec_changes branch July 22, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atye atye Awaiting requested review from atye

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

8 more reviewers

@bpjain2004 bpjain2004 bpjain2004 left review comments

@donatwork donatwork donatwork approved these changes

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@meggm meggm meggm left review comments

@karthikk92 karthikk92 karthikk92 left review comments

@suryagupta4 suryagupta4 suryagupta4 left review comments

@HarishH-DELL HarishH-DELL HarishH-DELL left review comments

@rishabhatdell rishabhatdell rishabhatdell left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@AkshaySainiDell @donatwork @meggm @bpjain2004 @nitesh3108 @karthikk92 @suryagupta4 @HarishH-DELL @rishabhatdell