Skip to content

Validation for maximum volumes per node before controller publish#416

Merged
karthikk92 merged 1 commit into
mainfrom
volume_limit_node
Jul 10, 2025
Merged

Validation for maximum volumes per node before controller publish#416
karthikk92 merged 1 commit into
mainfrom
volume_limit_node

Conversation

@karthikk92

@karthikk92 karthikk92 commented Jul 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Validation for maximum volumes per node before controller publish

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1896

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

k8s e2e test successful
CSI sanity test passing

@karthikk92 karthikk92 force-pushed the volume_limit_node branch from 327e51c to 59881f2 Compare July 9, 2025 14:30
@github-actions

github-actions Bot commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerscale/service 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerscale/service/controller.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/service/isiService.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerscale/service/controller_test.go
  • github.com/dell/csi-powerscale/service/isiService_test.go
  • github.com/dell/csi-powerscale/service/service_test.go
  • github.com/dell/csi-powerscale/service/step_handlers_test.go

@karthikk92 karthikk92 marked this pull request as ready for review July 9, 2025 15:08
@karthikk92 karthikk92 merged commit db4fabe into main Jul 10, 2025
6 checks passed
@karthikk92 karthikk92 deleted the volume_limit_node branch July 10, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atye atye Awaiting requested review from atye

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@chimanjain chimanjain Awaiting requested review from chimanjain

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@donatwork donatwork Awaiting requested review from donatwork

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

2 more reviewers

@meggm meggm meggm approved these changes

@sakshi-garg1 sakshi-garg1 sakshi-garg1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@karthikk92 @meggm @sakshi-garg1