Skip to content

Update ControllerPublishVolume to conform to CSI 1.6 Spec#411

Merged
suryagupta4 merged 1 commit into
mainfrom
usr/suryagupta4/controllerpublish-csi-spec-fix
Jun 26, 2025
Merged

Update ControllerPublishVolume to conform to CSI 1.6 Spec#411
suryagupta4 merged 1 commit into
mainfrom
usr/suryagupta4/controllerpublish-csi-spec-fix

Conversation

@suryagupta4

@suryagupta4 suryagupta4 commented Jun 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR addresses the following CSI Spec test scenarios for ControllerPublishVolume

  • should fail when the volume does not exist
  • should fail when the node does not exist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1896

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran csi-sanity test for ControllerPublishVolume
# ./csi-sanity --csi.endpoint=unix:///root/csi.sock --ginkgo.v  --ginkgo.focus='ControllerPublishVolume'
Running Suite: CSI Driver Test Suite - /root/csi-sanity
=======================================================
Random Seed: 1750861474

Will run 7 of 78 specs
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
------------------------------
.
.
.
• [0.001 seconds]
Controller Service [Controller Server]
/root/csi-sanity/csi-test-5.0.0/pkg/sanity/tests.go:45
  ControllerPublishVolume
  /root/csi-sanity/csi-test-5.0.0/pkg/sanity/controller.go:845
    should fail when the volume does not exist
    /root/csi-sanity/csi-test-5.0.0/pkg/sanity/controller.go:940

  Begin Captured GinkgoWriter Output >>
    STEP: reusing connection to CSI driver at unix:///root/csi.sock 06/25/25 09:24:34.337
    STEP: creating mount and staging directories 06/25/25 09:24:34.337
    STEP: calling controller publish on a non-existent volume 06/25/25 09:24:34.337
  << End Captured GinkgoWriter Output
.
.
.
• [4.628 seconds]
Controller Service [Controller Server]
/root/csi-sanity/csi-test-5.0.0/pkg/sanity/tests.go:45
  ControllerPublishVolume
  /root/csi-sanity/csi-test-5.0.0/pkg/sanity/controller.go:845
    should fail when the node does not exist
    /root/csi-sanity/csi-test-5.0.0/pkg/sanity/controller.go:962

  Begin Captured GinkgoWriter Output >>
    STEP: reusing connection to CSI driver at unix:///root/csi.sock 06/25/25 09:24:34.338
    STEP: creating mount and staging directories 06/25/25 09:24:34.338
    STEP: creating a single node writer volume 06/25/25 09:24:34.339
    STEP: calling controllerpublish on that volume 06/25/25 09:24:37.659
  << End Captured GinkgoWriter Output
.
.
.
------------------------------
SSSSSSSSSSSSSSSSSSS

Ran 5 of 78 Specs in 4.642 seconds
SUCCESS! -- 5 Passed | 0 Failed | 1 Pending | 72 Skipped

@github-actions

github-actions Bot commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerscale/service 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerscale/service/controller.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@suryagupta4 suryagupta4 self-assigned this Jun 25, 2025
@suryagupta4 suryagupta4 marked this pull request as ready for review June 25, 2025 14:28
@suryagupta4 suryagupta4 merged commit 6bfa28e into main Jun 26, 2025
6 checks passed
@suryagupta4 suryagupta4 deleted the usr/suryagupta4/controllerpublish-csi-spec-fix branch June 26, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atye atye Awaiting requested review from atye

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@chimanjain chimanjain Awaiting requested review from chimanjain

@donatwork donatwork Awaiting requested review from donatwork

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

@meggm meggm Awaiting requested review from meggm

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

2 more reviewers

@ChristianAtDell ChristianAtDell ChristianAtDell approved these changes

@santhoshatdell santhoshatdell santhoshatdell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@suryagupta4 suryagupta4

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@suryagupta4 @ChristianAtDell @santhoshatdell