Skip to content

Improve NodeGetVolumeStats with CSI Spec 1.6#410

Merged
rishabhatdell merged 3 commits into
mainfrom
fix_nodevolumegetstats
Jun 24, 2025
Merged

Improve NodeGetVolumeStats with CSI Spec 1.6#410
rishabhatdell merged 3 commits into
mainfrom
fix_nodevolumegetstats

Conversation

@rishabhatdell

Copy link
Copy Markdown
Contributor

Description

Enhancements to improve compliance with CSI Spec 1.6 and fix the abnormal message

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1896

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran csi-sanity for NodeGetVolumeStats
  • Ran cert-csi successfully

chimanjain
chimanjain previously approved these changes Jun 24, 2025
suryagupta4
suryagupta4 previously approved these changes Jun 24, 2025
@github-actions

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerscale/service 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerscale/service/node.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerscale/service/node_test.go

@rishabhatdell rishabhatdell merged commit f1f2174 into main Jun 24, 2025
6 checks passed
@rishabhatdell rishabhatdell deleted the fix_nodevolumegetstats branch June 24, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants