Skip to content

Update Node Services to conform to CSI 1.6#403

Merged
KshitijaKakde merged 4 commits into
mainfrom
csi_sanity_fixes
Jun 9, 2025
Merged

Update Node Services to conform to CSI 1.6#403
KshitijaKakde merged 4 commits into
mainfrom
csi_sanity_fixes

Conversation

@rishabhatdell

Copy link
Copy Markdown
Contributor

Description

This PR fixes two csi-sanity tests:

  • Node Service should work
  • Node Service should remove target path.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1896

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran csi-santiy for two tests
  • Ran cert-csi successfully

@rishabhatdell rishabhatdell changed the title Fix for csi-sanity node services Fix csi-sanity Node Services Jun 9, 2025
@rishabhatdell rishabhatdell changed the title Fix csi-sanity Node Services Update Node Services to conform to CSI 1.6 Jun 9, 2025
@rishabhatdell rishabhatdell marked this pull request as ready for review June 9, 2025 08:29
@github-actions

github-actions Bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerscale/service 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerscale/service/mount.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@KshitijaKakde KshitijaKakde merged commit 7523b58 into main Jun 9, 2025
6 checks passed
@KshitijaKakde KshitijaKakde deleted the csi_sanity_fixes branch June 9, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants