Skip to content

Update CreateVolume to conform to CSI 1.6#401

Merged
AkshaySainiDell merged 3 commits into
mainfrom
fix-createvolume-spec-16
Jun 9, 2025
Merged

Update CreateVolume to conform to CSI 1.6#401
AkshaySainiDell merged 3 commits into
mainfrom
fix-createvolume-spec-16

Conversation

@AkshaySainiDell

@AkshaySainiDell AkshaySainiDell commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

Description

Enhancements to improve compliance with CSI spec: 1.6.
CreateVolume should fail when requesting to create a volume with already existing name and different capacity

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1896

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran csi-santiy and verified that no existing tests are failing and that the CreateVolume test pass
  • Ran cert-csi successfully

@AkshaySainiDell AkshaySainiDell changed the title [WIP] Fix CreateVolume : should fail with existing name and different capacity [WIP] Update CreateVolume to conform to CSI 1.6 Jun 6, 2025
@github-actions

github-actions Bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerscale/service 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerscale/service/controller.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerscale/service/step_defs_test.go
  • github.com/dell/csi-powerscale/service/step_handlers_test.go

@AkshaySainiDell AkshaySainiDell marked this pull request as ready for review June 9, 2025 06:40
@AkshaySainiDell AkshaySainiDell changed the title [WIP] Update CreateVolume to conform to CSI 1.6 Update CreateVolume to conform to CSI 1.6 Jun 9, 2025
@AkshaySainiDell AkshaySainiDell merged commit 2e7c071 into main Jun 9, 2025
6 checks passed
@AkshaySainiDell AkshaySainiDell deleted the fix-createvolume-spec-16 branch June 9, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants