Skip to content

Update DeleteVolume to conform to CSI 1.6#397

Merged
sakshi-garg1 merged 2 commits into
mainfrom
fix_delete_volume_tests
Jun 9, 2025
Merged

Update DeleteVolume to conform to CSI 1.6#397
sakshi-garg1 merged 2 commits into
mainfrom
fix_delete_volume_tests

Conversation

@sakshi-garg1

@sakshi-garg1 sakshi-garg1 commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

Description

This PR fixes one csi-sanity tests for the Delete volume where invalid volume id is passed.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1896

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran csi-santiy for this deletevolume scenario

image

  • Ran cert-csi successfully
    image

@sakshi-garg1 sakshi-garg1 self-assigned this Jun 5, 2025
@sakshi-garg1 sakshi-garg1 changed the title []WIP:Update DeleteVolume to conform to CSI 1.6 [WIP]:Update DeleteVolume to conform to CSI 1.6 Jun 5, 2025
@sakshi-garg1 sakshi-garg1 marked this pull request as ready for review June 6, 2025 12:03
@sakshi-garg1 sakshi-garg1 changed the title [WIP]:Update DeleteVolume to conform to CSI 1.6 Update DeleteVolume to conform to CSI 1.6 Jun 6, 2025
donatwork
donatwork previously approved these changes Jun 6, 2025
Comment thread service/controller.go Outdated
Comment thread service/controller.go Outdated
Comment thread service/controller.go
AkshaySainiDell
AkshaySainiDell previously approved these changes Jun 9, 2025
rishabhatdell
rishabhatdell previously approved these changes Jun 9, 2025
Comment thread service/controller.go Outdated
@sakshi-garg1 sakshi-garg1 force-pushed the fix_delete_volume_tests branch from 1644fd7 to f5cd37e Compare June 9, 2025 10:05
@github-actions

github-actions Bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerscale/service 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerscale/service/controller.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@sakshi-garg1 sakshi-garg1 merged commit 947f877 into main Jun 9, 2025
6 checks passed
@sakshi-garg1 sakshi-garg1 deleted the fix_delete_volume_tests branch June 9, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants