Skip to content

Use the remote certificate id during reprotect operation#377

Merged
tdawe merged 2 commits into
mainfrom
usr/tdawe/fix-replication-certificate
Apr 22, 2025
Merged

Use the remote certificate id during reprotect operation#377
tdawe merged 2 commits into
mainfrom
usr/tdawe/fix-replication-certificate

Conversation

@tdawe

@tdawe tdawe commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

Description

When using PowerScale replication with SyncIQ replication, the failback action failed due to an incorrect certificate id in the request. This fixes the call to use

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1834

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Full run of Replication e2e for PowerScale was successful.
PASS
status 0
ok      karavi-testing/karavi-replication/replication-test      1317.284s
  • Verified private build using PowerScale with SyncIQ replication.

@tdawe tdawe force-pushed the usr/tdawe/fix-replication-certificate branch from 9100278 to c339c45 Compare April 14, 2025 15:07
Comment thread service/replication.go
@tdawe tdawe changed the title Use the remote certificate id during failback operation Use the remote certificate id during reprotect operation Apr 14, 2025
Comment thread service/replication.go
@github-actions

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerscale/service 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerscale/service/replication.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@tdawe tdawe merged commit 5c59c5c into main Apr 22, 2025
@tdawe tdawe deleted the usr/tdawe/fix-replication-certificate branch April 22, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants