KubeVirt support files#341
Conversation
the stringent pass criteria, including service/mocks.
| # common: | ||
| # name: Quality Checks | ||
| # uses: dell/common-github-actions/.github/workflows/go-common.yml@main |
There was a problem hiding this comment.
Shouldn't these commented out lines be removed?
There was a problem hiding this comment.
We should keep this action as part of our code quality checks. This is a consistent check across all the repos
There was a problem hiding this comment.
When I initally committed with no code changes, the workflow UT failed. The new unit-test-workflow.yaml takes the place of these lines. If there is an alternative that uses the common workflow and excludes the directories on line 31 in the unit-test-workflow.yaml, then I can change this.
| # common: | ||
| # name: Quality Checks | ||
| # uses: dell/common-github-actions/.github/workflows/go-common.yml@main |
There was a problem hiding this comment.
We should keep this action as part of our code quality checks. This is a consistent check across all the repos
| @@ -0,0 +1,31 @@ | |||
| name: Code Test | |||
There was a problem hiding this comment.
This is a duplicate to what dell/common-github-actions/.github/workflows/go-common.yml@main is running, can this file be removed?
There was a problem hiding this comment.
I added this file to put in the exclusions on line 31 since this workflow UT check is a new failure on those directories " exclude-directory: "service/mock|provider|core|service/interceptor|common/constants|csi-utils|test/integration|common/k8sutils|core/semver|common/utils|v2". Is there another way to do this other than adding this file?
There was a problem hiding this comment.
Yes, any exclusions have to be added by a repo admin in the repo settings now. When UT coverage is increased, will any of these packages still be testable?
There was a problem hiding this comment.
Honestly I don't know as of yet. It's possible some of them are testable since they have go code in them. seem logical to me.
the common workflow as per review comments.
|
|
Description
Adding support files required for KubeVirt testing. No code changes.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration