Skip to content

Add Check for Hard Limit in ControllerExpandVolume#335

Merged
suryagupta4 merged 3 commits into
mainfrom
usr/kshitija/fix-hardlimit
Feb 25, 2025
Merged

Add Check for Hard Limit in ControllerExpandVolume#335
suryagupta4 merged 3 commits into
mainfrom
usr/kshitija/fix-hardlimit

Conversation

@KshitijaKakde

@KshitijaKakde KshitijaKakde commented Jan 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Add Check for Hard Limit Not Set to 0 in ControllerExpandVolume

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1726

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

  1. Reproduced the issue by installing the driver, creating a filesystem, removing the hard limit from the array, and attempting to expand the volume. The error message observed was: panic: runtime error: integer divide by zero.
  2. Built a new image with the fix and installed the driver with this new image.
  3. Attempted to expand the filesystem by removing the hard limit from the array. The following error message was observed: "Hard limit is 0, cannot proceed with volume expansion."

@KshitijaKakde KshitijaKakde marked this pull request as ready for review February 3, 2025 12:11
donatwork
donatwork reviewed Feb 3, 2025
View reviewed changes
Comment thread service/controller.go
@suryagupta4 suryagupta4 merged commit 458d82d into main Feb 25, 2025
@suryagupta4 suryagupta4 deleted the usr/kshitija/fix-hardlimit branch February 25, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atye atye Awaiting requested review from atye

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

@meggm meggm Awaiting requested review from meggm

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

4 more reviewers

@donatwork donatwork donatwork left review comments

@chimanjain chimanjain chimanjain approved these changes

@karthikk92 karthikk92 karthikk92 approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KshitijaKakde @donatwork @chimanjain @karthikk92 @suryagupta4