Skip to content

Handle panic error snapshot#303

Merged
jackieung-dell merged 3 commits into
mainfrom
handle-panic-error-snapshotID
Nov 26, 2024
Merged

Handle panic error snapshot#303
jackieung-dell merged 3 commits into
mainfrom
handle-panic-error-snapshotID

Conversation

@jackieung-dell

@jackieung-dell jackieung-dell commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

Description

  • Updated ParseNormalizedSnapshotID() to prevent a panic error message when accessing an index out of range.
  • Improved code coverage to 80% as required by new workflow checks.

Note: Commits are from this PR #294

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1620

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

The issue was not reproducible, so @jackieung-dell made sure that the panic error is handled and added a unit test for it.

@kumarkgosa kumarkgosa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackieung-dell jackieung-dell merged commit 06854b5 into main Nov 26, 2024
@jackieung-dell jackieung-dell deleted the handle-panic-error-snapshotID branch November 26, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants