Skip to content

Not return unimplemented capabilities#301

Merged
EvgenyUglov merged 4 commits into
mainfrom
pvt/not-return-unimplemented-capabilities
Nov 26, 2024
Merged

Not return unimplemented capabilities#301
EvgenyUglov merged 4 commits into
mainfrom
pvt/not-return-unimplemented-capabilities

Conversation

@EvgenyUglov

@EvgenyUglov EvgenyUglov commented Nov 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes #1708 and removes STAGE_UNSTAGE_VOLUME unimplemented node capability from the returned list

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1708

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • make unit-test
  • Installed PowerStore driver and checked the list of capabilities
[root@master-1-AevzcJKPoLLnD samples]# kubectl logs isilon-node-z5dkt -n isilon | grep STAGE
[root@master-1-AevzcJKPoLLnD samples]# kubectl logs isilon-node-z5dkt -n isilon | grep rpc
time="2024-11-22T17:45:22Z" level=info msg="/csi.v1.Node/NodeGetCapabilities: REP 0003: Capabilities=[rpc:<type:SINGLE_NODE_MULTI_WRITER >  rpc:<type:GET_VOLUME_STATS >  rpc:<type:VOLUME_CONDITION > ], XXX_NoUnkeyedLiteral={}, XXX_sizecache=0"

santhoshatdell
santhoshatdell reviewed Nov 25, 2024
View reviewed changes
Comment thread service/node.go Outdated
@EvgenyUglov EvgenyUglov changed the title Pvt/not return unimplemented capabilities Not return unimplemented capabilities Nov 26, 2024
@EvgenyUglov EvgenyUglov marked this pull request as ready for review November 26, 2024 22:23
@santhoshatdell

santhoshatdell commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

@EvgenyUglov Could you rebase the branch? All checks should pass now.

@EvgenyUglov

EvgenyUglov commented Nov 26, 2024

Copy link
Copy Markdown
Contributor Author

@EvgenyUglov Could you rebase the branch? All checks should pass now.

Done

@EvgenyUglov EvgenyUglov merged commit 30f5a5f into main Nov 26, 2024
@EvgenyUglov EvgenyUglov deleted the pvt/not-return-unimplemented-capabilities branch November 26, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atye atye Awaiting requested review from atye

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@chimanjain chimanjain Awaiting requested review from chimanjain

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@donatwork donatwork Awaiting requested review from donatwork

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

@meggm meggm Awaiting requested review from meggm

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

2 more reviewers

@jackieung-dell jackieung-dell jackieung-dell approved these changes

@santhoshatdell santhoshatdell santhoshatdell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EvgenyUglov @santhoshatdell @jackieung-dell