Skip to content

Makefile check target cleanup#297

Merged
mjsdell merged 2 commits into
mainfrom
MakefileCleanup
Nov 18, 2024
Merged

Makefile check target cleanup#297
mjsdell merged 2 commits into
mainfrom
MakefileCleanup

Conversation

@mjsdell

@mjsdell mjsdell commented Nov 18, 2024

Copy link
Copy Markdown
Collaborator

Description

Cleaning up old check script and check make target. Linting, vetting and formatting checks will be done in the new GitHub Actions going forward.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@AronAtDell AronAtDell left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks are being done in the actions.

@mjsdell mjsdell merged commit f249cf4 into main Nov 18, 2024
@mjsdell mjsdell deleted the MakefileCleanup branch November 18, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants