Update Makefile to remove check target#296
Merged
Merged
Conversation
Remove check target from build target.
AronAtDell
approved these changes
Nov 18, 2024
AronAtDell
left a comment
There was a problem hiding this comment.
Thanks @mjsdell for getting this done! It is covered in the actions.
donatwork
approved these changes
Nov 18, 2024
|
|
||
| # Build the driver locally | ||
| build: dependencies check | ||
| build: dependencies |
Collaborator
There was a problem hiding this comment.
Is the make check target and check.sh still needed now that linting is done in the PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove check target from build target.
Description
With the introduction of the GitHub Actions to cover vetting, linting, formatting, etc we are now removing the check target from the Makefile to consolidate the tooling.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration