Added make target to build without cache#278
Merged
Merged
Conversation
Collaborator
Author
|
|
alexemc
suggested changes
Sep 3, 2024
Comment on lines
+21
to
+30
| podman-build-no-cache: download-csm-common | ||
| $(eval include csm-common.mk) | ||
| @echo "Base Image is set to: $(DEFAULT_BASEIMAGE)" | ||
| @echo "Adding Driver dependencies to $(DEFAULT_BASEIMAGE)" | ||
| bash ./buildubimicro.sh $(DEFAULT_BASEIMAGE) | ||
| @echo "Base image build: SUCCESS" $(eval BASEIMAGE=localhost/csipowerscale-ubimicro:latest) | ||
| @echo "Building: $(REGISTRY)/$(IMAGENAME):$(IMAGETAG)" | ||
| @echo "Using Golang Image $(DEFAULT_GOIMAGE)" | ||
| $(BUILDER) build --no-cache -t "$(REGISTRY)/$(IMAGENAME):$(IMAGETAG)" -f Dockerfile.podman --target $(BUILDSTAGE) --build-arg GOPROXY=$(GOPROXY) --build-arg BASEIMAGE=$(BASEIMAGE) --build-arg GOIMAGE=$(DEFAULT_GOIMAGE) . | ||
|
|
Contributor
There was a problem hiding this comment.
I suggest removing the code duplication with something like this:
podman-build: download-csm-common
$(eval include csm-common.mk)
@echo "Base Image is set to: $(DEFAULT_BASEIMAGE)"
@echo "Adding Driver dependencies to $(DEFAULT_BASEIMAGE)"
bash ./buildubimicro.sh $(DEFAULT_BASEIMAGE)
@echo "Base image build: SUCCESS" $(eval BASEIMAGE=localhost/csipowerscale-ubimicro:latest)
@echo "Building: $(REGISTRY)/$(IMAGENAME):$(IMAGETAG)"
@echo "Using Golang Image $(DEFAULT_GOIMAGE)"
$(BUILDER) build $(NOCACHE) -t "$(REGISTRY)/$(IMAGENAME):$(IMAGETAG)" -f Dockerfile.podman --target $(BUILDSTAGE) --build-arg GOPROXY=$(GOPROXY) --build-arg BASEIMAGE=$(BASEIMAGE) --build-arg GOIMAGE=$(DEFAULT_GOIMAGE) .
podman-build-no-cache:
@echo "Building with --no-cache ..."
@make podman-build NOCACHE=--no-cache
alexemc
approved these changes
Sep 3, 2024
donatwork
approved these changes
Sep 3, 2024
bpjain2004
approved these changes
Sep 4, 2024
nitesh3108
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Image build job fails because of no space left on the build machine. This is caused by overlay images created during the build process
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration