Skip to content

Update offline installer to ignore comments in the manifests.#277

Merged
rodrigobassil merged 6 commits into
mainfrom
update_offline_installer
Aug 28, 2024
Merged

Update offline installer to ignore comments in the manifests.#277
rodrigobassil merged 6 commits into
mainfrom
update_offline_installer

Conversation

@rodrigobassil

@rodrigobassil rodrigobassil commented Aug 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Update offline installer to ignore comments in the manifests.

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

./csi-offline-bundle.sh -c

  • Building image manifest file

    Processing files in /root/workspacecsm/csi-powerscale/helm-charts/charts/csi-isilon

  • Pulling and saving container images

    dellemc/csi-isilon:v2.11.0
    dellemc/csi-metadata-retriever:v1.8.0
    dellemc/csm-authorization-sidecar:v1.11.0
    dellemc/csm-encryption:v0.6.0
    dellemc/dell-csi-replicator:v1.9.0
    dellemc/podmon:v1.10.0
    registry.k8s.io/sig-storage/csi-attacher:v4.6.1
    registry.k8s.io/sig-storage/csi-external-health-monitor-controller:v0.12.1
    registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.10.1
    registry.k8s.io/sig-storage/csi-provisioner:v5.0.1
    registry.k8s.io/sig-storage/csi-resizer:v1.11.1
    registry.k8s.io/sig-storage/csi-snapshotter:v8.0.1

  • Copying necessary files

/root/workspacecsm/csi-powerscale/helm-charts/charts/csi-isilon
/root/workspacecsm/csi-powerscale/dell-csi-helm-installer
/root/workspacecsm/csi-powerscale/README.md
/root/workspacecsm/csi-powerscale/LICENSE

  • Compressing release

csi-isilon-bundle-2.11.0/
csi-isilon-bundle-2.11.0/helm-charts/
csi-isilon-bundle-2.11.0/helm-charts/charts/
csi-isilon-bundle-2.11.0/helm-charts/charts/csi-isilon/
csi-isilon-bundle-2.11.0/helm-charts/charts/csi-isilon/Chart.yaml
csi-isilon-bundle-2.11.0/helm-charts/charts/csi-isilon/values.yaml
csi-isilon-bundle-2.11.0/helm-charts/charts/csi-isilon/templates/
csi-isilon-bundle-2.11.0/helm-charts/charts/csi-isilon/templates/sec-rolebinding.yaml
csi-isilon-bundle-2.11.0/helm-charts/charts/csi-isilon/templates/node.yaml
csi-isilon-bundle-2.11.0/helm-charts/charts/csi-isilon/templates/_helpers.tpl
csi-isilon-bundle-2.11.0/helm-charts/charts/csi-isilon/templates/validation.yaml
csi-isilon-bundle-2.11.0/helm-charts/charts/csi-isilon/templates/csidriver.yaml
csi-isilon-bundle-2.11.0/helm-charts/charts/csi-isilon/templates/driver-config-params.yaml
csi-isilon-bundle-2.11.0/helm-charts/charts/csi-isilon/templates/controller.yaml
csi-isilon-bundle-2.11.0/LICENSE
csi-isilon-bundle-2.11.0/README.md
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/common.sh
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/images.tar/
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-attacher-v4.6.1.tar
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-resizer-v1.11.1.tar
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-snapshotter-v8.0.1.tar
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/images.tar/dellemc-dell-csi-replicator-v1.9.0.tar
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-node-driver-registrar-v2.10.1.tar
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-external-health-monitor-controller-v0.12.1.tar
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/images.tar/dellemc-podmon-v1.10.0.tar
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/images.tar/dellemc-csi-isilon-v2.11.0.tar
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/images.tar/dellemc-csm-encryption-v0.6.0.tar
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-provisioner-v5.0.1.tar
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/images.tar/dellemc-csm-authorization-sidecar-v1.11.0.tar
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/images.tar/dellemc-csi-metadata-retriever-v1.8.0.tar
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/csi-offline-bundle.md
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/.gitignore
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/verify-csi-isilon.sh
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/README.md
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/csi-install.sh
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/images.manifest
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/verify.sh
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/csi-uninstall.sh
csi-isilon-bundle-2.11.0/dell-csi-helm-installer/csi-offline-bundle.sh

  • Complete

Offline bundle file is: /root/workspacecsm/csi-powerscale/csi-isilon-bundle-2.11.0.tar.gz

atye
atye previously approved these changes Aug 28, 2024
View reviewed changes
santhoshatdell
santhoshatdell previously approved these changes Aug 28, 2024
View reviewed changes
@santhoshatdell

santhoshatdell commented Aug 28, 2024

Copy link
Copy Markdown
Contributor

There are few lint errors. Could you fix them?

donatwork
donatwork previously approved these changes Aug 28, 2024
View reviewed changes
@rodrigobassil rodrigobassil dismissed stale reviews from donatwork, santhoshatdell, and atye via cec1d9c August 28, 2024 13:39
santhoshatdell
santhoshatdell previously approved these changes Aug 28, 2024
View reviewed changes
@rodrigobassil rodrigobassil merged commit f7b29c1 into main Aug 28, 2024
@rodrigobassil rodrigobassil deleted the update_offline_installer branch August 28, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@bogdanNovikovDell bogdanNovikovDell Awaiting requested review from bogdanNovikovDell

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@chimanjain chimanjain Awaiting requested review from chimanjain

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

@Leonard-Dell Leonard-Dell Awaiting requested review from Leonard-Dell

@mdutka-dell mdutka-dell Awaiting requested review from mdutka-dell

@meggm meggm Awaiting requested review from meggm

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

+3 more reviewers

@atye atye atye approved these changes

@donatwork donatwork donatwork approved these changes

@santhoshatdell santhoshatdell santhoshatdell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rodrigobassil @santhoshatdell @atye @donatwork @shaynafinocchiaro