Remove mutex locks from interceptors on method calls#276
Merged
Conversation
Contributor
|
@chimanjain please ensure all Checklist verified and ensure all test results attached in the ticket for detail review of this PR. Thank you! |
Contributor
|
Have you considered a ROX volume scenario where same volume is mounted against multiple nodes. |
9167566 to
8e32645
Compare
Contributor
Author
Yes, it was tested against RWX, RWO, ROX access mode |
HarishH-DELL
approved these changes
Aug 29, 2024
shefali-malhotra
left a comment
Contributor
There was a problem hiding this comment.
Hopefully you have verified setting of quota limit parameters in volume with these changes. If not, please verify and update the test results in PR.
Contributor
Author
shefali-malhotra
approved these changes
Aug 30, 2024
shefali-malhotra
left a comment
Contributor
There was a problem hiding this comment.
LGTM . Considering sufficient regression testing has already been performed with these changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Improve performance by removing mutex calls from interceptors on method calls. Reducing unnecessary synchronization can decrease overhead and enhance system efficiency.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration