Use volume name that got created at array is return to caller by alikdell · Pull Request #273 · dell/csi-powerscale

alikdell · 2024-08-14T15:12:43Z

Description

Use volume name that got created at array is return to caller in this case k8s.
To support tenant base volume prefix create volume is intercepted in CSM for Authorization and add a volume name prefix.
Volume is created with provided prefix. Current driver code do not read the return name. This PR will make sure volume name is return.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#https://github.com/dell/csm/issues/1281

Checklist:

I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
I have verified that new and existing unit tests pass locally with my changes
I have not allowed coverage numbers to degenerate
I have maintained at least 90% code coverage
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

[cert-csi]# ./cert-csi test vio --sc isilon --chainNumber 2 --chainLength 2
[cert-csi]# make unit-test passed
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Transfer-Encoding: chunked
Content-Type: text/plain; charset=utf-8
Date: Thu, 15 Aug 2024 16:39:17 GMT

[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
PUT /platform/2/protocols/nfs/exports/557?zone=System HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:******
Content-Type: application/json

{"root_clients":["vpi7125.a.b.com"]}

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: PUT /platform/2/protocols/nfs/exports/557?zone=System"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 204 No Content
Content-Length: 0
Date: Thu, 15 Aug 2024 16:39:17 GMT

time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="updating ClusterToNodeIDMap map for cluster 'cluster1', for nodeID 'vpi7125=#=#=vpi7125.a.b.com=#=#=1.1.1.1' with clientToUse 'vpi7125.a.b.com'" file="/root/CSM/csi-powerscale/service/isiService.go:518"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="entry for cluster 'cluster1' found in cluster to nodeID map" file="/root/CSM/csi-powerscale/service/isiService.go:523"
�[32mAnd�[0m �[32mI call ControllerPublishVolume on Snapshot with name "snapVol1===43===System" and access type "multiple-reader" to "vpi7125=#=#=vpi7125.a.b.com=#=#=1.1.1.1" and path "/ifs/.snapshot/snapshot-snappath"�[0m �[1;30m# :1 -> *feature�[0m
�[32mThen�[0m �[32ma valid ControllerPublishVolumeResponse is returned�[0m �[1;30m# :1 -> *feature�[0m
volume 'volume1'
�[32mThen�[0m �[32ma valid CreateVolumeResponse is returned�[0m �[1;30m# :1 -> *feature�[0m
goroutines start aIsilonService new 1149 old groutines 1149
2024/08/15 12:39:17 server url: http://127.0.0.1:33989
time="2024-08-15T12:39:17-04:00" level=error msg="init client failed for isilon cluster 'cluster1': 'missing endpoint, username, or password'" file="/root/CSM/csi-powerscale/service/service.go:459"
goroutines end aIsilonService new 1149 old groutines 1149
time="2024-08-15T12:39:17-04:00" level=info msg="Configured 'csi-isilon.dellemc.com'" accesspoint=System autoprobe=true mode=controller path=/ifs/data/csi-isilon quotaenabled=false skipCertificateValidation=true

�[1;37mScenario:�[0m Call ProbeController with invalid input �[1;30m# features/service.feature:542�[0m
�[32mGiven�[0m �[32ma Isilon service with params "" "controller"�[0m �[1;30m# :1 -> feature�[0m
time="2024-08-15T12:39:17-04:00" level=debug msg="controllerProbe" file="/root/CSM/csi-powerscale/service/service.go:1037"
time="2024-08-15T12:39:17-04:00" level=debug msg="calling probe for cluster 'cluster1'" file="/root/CSM/csi-powerscale/service/service.go:323"
time="2024-08-15T12:39:17-04:00" level=debug msg="Probe failed for isilon cluster 'cluster1' error:'controller probe failed : 'invalid isi service parameters, at least one of endpoint, username and password is empty. endpoint : endpoint '127.0.0.1', username : ''''" file="/root/CSM/csi-powerscale/service/service.go:310"
time="2024-08-15T12:39:17-04:00" level=error msg="error in controllerProbe: probe of all isilon clusters failed" file="/root/CSM/csi-powerscale/service/service.go:1039"
�[32mAnd�[0m �[32mI call ProbeController�[0m �[1;30m# :1 -> feature�[0m
�[32mThen�[0m �[32mthe error contains "probe of all isilon clusters failed"�[0m �[1;30m# :1 -> feature�[0m
goroutines start aIsilonService new 1149 old groutines 1149
time="2024-08-15T12:39:17-04:00" level=info msg="Registering additional GRPC servers" file="/root/CSM/csi-powerscale/service/service.go:550"
2024/08/15 12:39:17 server url: http://127.0.0.1:33989
[DEBUG] opts.Insecure : 'true'
[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
GET /platform/latest/ HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:***

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: GET /platform/latest/"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Content-Length: 17
Content-Type: text/plain; charset=utf-8
Date: Thu, 15 Aug 2024 16:39:17 GMT

goroutines end aIsilonService new 1152 old groutines 1149
time="2024-08-15T12:39:17-04:00" level=info msg="Configured 'csi-isilon.dellemc.com'" accesspoint=System autoprobe=false mode=controller path=/ifs/data/csi-isilon quotaenabled=false skipCertificateValidation=true

�[1;37mScenario:�[0m ControllerGetVolume export does not exist scenario �[1;30m# features/service.feature:547�[0m
�[32mGiven�[0m �[32ma Isilon service�[0m �[1;30m# :1 -> feature�[0m
goroutines before probe new 1152 old groutines 1152
time="2024-08-15T12:39:17-04:00" level=debug msg="calling probe for cluster 'cluster1'" file="/root/CSM/csi-powerscale/service/service.go:323"
time="2024-08-15T12:39:17-04:00" level=debug msg="test connection client, user name : 'blah'" file="/root/CSM/csi-powerscale/service/isiService.go:380"
[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
GET /platform/3/cluster/config/ HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:*****

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: GET /platform/3/cluster/config/"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Content-Length: 1387
Content-Type: text/plain; charset=utf-8
Date: Thu, 15 Aug 2024 16:39:17 GMT

time="2024-08-15T12:39:17-04:00" level=debug msg="test connection succeeded" file="/root/CSM/csi-powerscale/service/isiService.go:386"
time="2024-08-15T12:39:17-04:00" level=debug msg="controller probe succeeded" file="/root/CSM/csi-powerscale/service/controller.go:1601"
time="2024-08-15T12:39:17-04:00" level=debug msg="Probe returning: true" file="/root/CSM/csi-powerscale/service/identity.go:97"
goroutines after probe new 1152 old groutines 1152
�[32mWhen�[0m �[32mI call Probe�[0m �[1;30m# :1 -> feature�[0m
2024/08/15 12:39:17 set induce error GetExportInternalError
�[32mAnd�[0m �[32mI induce error "GetExportInternalError"�[0m �[1;30m# :1 -> feature�[0m
Calling controllerGetVolumetime="2024-08-15T12:39:17-04:00" level=debug runid=1 msg="volume ID 'volume2===43===System===cluster1' parsed into volume name 'volume2', export ID '43', access zone 'System' and cluster name 'cluster1'" file="/root/CSM/csi-powerscale/common/utils/utils.go:357"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="Cluster Name: cluster1" file="/root/CSM/csi-powerscale/service/controller.go:1986"
time="2024-08-15T12:39:17-04:00" level=error clusterName=cluster1 runid=1 msg="Failed get isiPathno k8s clientset" file="/root/CSM/csi-powerscale/service/controller.go:1998"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="isiSvc already initialized, skip probing" file="/root/CSM/csi-powerscale/service/service.go:376"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="check if volume (id :'volume2', name '') already exists" file="/root/CSM/csi-powerscale/service/isiService.go:456"
[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
GET /namespace/ifs/data/csi-isilon/volume2 HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:****

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: GET /namespace/ifs/data/csi-isilon/volume2"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Content-Length: 100
Content-Type: text/plain; charset=utf-8
Date: Thu, 15 Aug 2024 16:39:17 GMT

[DEBUG] the query of volume (id 'volume2', name 'volume2') did not return an error, regard the volume as existent.
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="volume (id :'volume2', name '') already exists : 'true'" file="/root/CSM/csi-powerscale/service/isiService.go:460"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="begin getting volume with id '' and name 'volume2' for Isilon" file="/root/CSM/csi-powerscale/service/isiService.go:399"
[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
GET /namespace/ifs/data/csi-isilon/volume2?metadata HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:******

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: GET /namespace/ifs/data/csi-isilon/volume2?metadata"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Content-Length: 100
Content-Type: text/plain; charset=utf-8
Date: Thu, 15 Aug 2024 16:39:17 GMT

time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="begin getting export by id '43' with access zone 'System' for Isilon" file="/root/CSM/csi-powerscale/service/isiService.go:133"
[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
GET /platform/2/protocols/nfs/exports/43?zone=System HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:******

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: GET /platform/2/protocols/nfs/exports/43?zone=System"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 500 Internal Server Error
Date: Thu, 15 Aug 2024 16:39:17 GMT
Content-Length: 0

time="2024-08-15T12:39:17-04:00" level=error clusterName=cluster1 runid=1 msg="failed to get export by id with access zone" file="/root/CSM/csi-powerscale/service/isiService.go:138"
Expected controllerGetVolumeResponse.Abnormal to be false, and message to contain: , but instead, abnormal was: true and message was: unable to fetch export list �[32mAnd�[0m �[32mI call ControllerGetVolume with name "volume2===43===System===cluster1"�[0m �[1;30m# :1 -> feature�[0m
�[32mThen�[0m �[32mthe error contains "none"�[0m �[1;30m# :1 -> feature�[0m
goroutines start aIsilonService new 1152 old groutines 1152
time="2024-08-15T12:39:17-04:00" level=info msg="Registering additional GRPC servers" file="/root/CSM/csi-powerscale/service/service.go:550"
2024/08/15 12:39:17 server url: http://127.0.0.1:33989
[DEBUG] opts.Insecure : 'true'
[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
GET /platform/latest/ HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:****

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: GET /platform/latest/"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Content-Length: 17
Content-Type: text/plain; charset=utf-8
Date: Thu, 15 Aug 2024 16:39:17 GMT

goroutines end aIsilonService new 1155 old groutines 1152
time="2024-08-15T12:39:17-04:00" level=info msg="Configured 'csi-isilon.dellemc.com'" accesspoint=System autoprobe=false mode=controller path=/ifs/data/csi-isilon quotaenabled=false skipCertificateValidation=true

�[1;37mScenario:�[0m Create RO volume from snapshot with NodePublishVolume �[1;30m# features/service.feature:554�[0m
�[32mGiven�[0m �[32ma Isilon service�[0m �[1;30m# :1 -> feature�[0m
goroutines before probe new 1155 old groutines 1155
time="2024-08-15T12:39:17-04:00" level=debug msg="calling probe for cluster 'cluster1'" file="/root/CSM/csi-powerscale/service/service.go:323"
time="2024-08-15T12:39:17-04:00" level=debug msg="test connection client, user name : 'blah'" file="/root/CSM/csi-powerscale/service/isiService.go:380"
[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
GET /platform/3/cluster/config/ HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:*****

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: GET /platform/3/cluster/config/"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Content-Length: 1387
Content-Type: text/plain; charset=utf-8
Date: Thu, 15 Aug 2024 16:39:17 GMT

time="2024-08-15T12:39:17-04:00" level=debug msg="test connection succeeded" file="/root/CSM/csi-powerscale/service/isiService.go:386"
time="2024-08-15T12:39:17-04:00" level=debug msg="controller probe succeeded" file="/root/CSM/csi-powerscale/service/controller.go:1601"
time="2024-08-15T12:39:17-04:00" level=debug msg="Probe returning: true" file="/root/CSM/csi-powerscale/service/identity.go:97"
goroutines after probe new 1155 old groutines 1155
�[32mWhen�[0m �[32mI call Probe�[0m �[1;30m# :1 -> feature�[0m
2024/08/15 12:39:17 called iCallCreateVolumeFromSnapshotMultiReader
time="2024-08-15T12:39:17-04:00" level=info msg="Request doesn't include cluster name. Use default cluster 'cluster1'" file="/root/CSM/csi-powerscale/service/service.go:998"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="Cluster Name: cluster1" file="/root/CSM/csi-powerscale/service/controller.go:265"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="isiSvc already initialized, skip probing" file="/root/CSM/csi-powerscale/service/service.go:376"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="Replication flag unset" file="/root/CSM/csi-powerscale/service/controller.go:317"
time="2024-08-15T12:39:17-04:00" level=info clusterName=cluster1 msg="Limit parameters considered for quota creation SoftLimit: '' , AdvisoryLimit: '',SoftGracePrd: ''" file="/root/CSM/csi-powerscale/service/controller.go:352"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="normalized snapshot ID '43' parsed into snapshot ID '43' and cluster name ''" file="/root/CSM/csi-powerscale/common/utils/utils.go:393"
time="2024-08-15T12:39:17-04:00" level=info clusterName=cluster1 msg="Creating volume from snapshot ID: '43'" file="/root/CSM/csi-powerscale/service/controller.go:375"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="begin getting snapshot with id|name '43' for Isilon" file="/root/CSM/csi-powerscale/service/isiService.go:746"
[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
GET /platform/1/snapshot/snapshots/43/ HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:*****

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: GET /platform/1/snapshot/snapshots/43/"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Content-Length: 366
Content-Type: text/plain; charset=utf-8
Date: Thu, 15 Aug 2024 16:39:17 GMT

time="2024-08-15T12:39:17-04:00" level=info clusterName=cluster1 msg="Snapshot source volume isiPath is '/ifs/data/yian' accessZone 'System'" file="/root/CSM/csi-powerscale/service/controller.go:381"
[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
GET /platform/1/snapshot/snapshots/43/ HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:******

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: GET /platform/1/snapshot/snapshots/43/"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Content-Length: 366
Content-Type: text/plain; charset=utf-8
Date: Thu, 15 Aug 2024 16:39:17 GMT

[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
GET /platform/1/zones/System HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:******

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: GET /platform/1/zones/System"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Content-Length: 550
Content-Type: text/plain; charset=utf-8
Date: Thu, 15 Aug 2024 16:39:17 GMT

time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="The Isilon directory path of snapshot is= '/ifs/.snapshot/existent_snapshot_name/data/yian/nfs_1'" file="/root/CSM/csi-powerscale/service/controller.go:386"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="begin getting snapshot with id|name '43' for Isilon" file="/root/CSM/csi-powerscale/service/isiService.go:746"
[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
GET /platform/1/snapshot/snapshots/43/ HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:******

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: GET /platform/1/snapshot/snapshots/43/"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Content-Length: 366
Content-Type: text/plain; charset=utf-8
Date: Thu, 15 Aug 2024 16:39:17 GMT

time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="check if volume (id :'', name '.csi-existent_snapshot_name-tracking-dir/snapVol1') already exists" file="/root/CSM/csi-powerscale/service/isiService.go:456"
[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
GET /namespace/ifs/data/yian/.csi-existent_snapshot_name-tracking-dir/snapVol1 HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:******

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: GET /namespace/ifs/data/yian/.csi-existent_snapshot_name-tracking-dir/snapVol1"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Date: Thu, 15 Aug 2024 16:39:17 GMT
Content-Length: 0

[DEBUG] the query of volume (id '', name '.csi-existent_snapshot_name-tracking-dir/snapVol1') did not return an error, regard the volume as existent.
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="volume (id :'', name '.csi-existent_snapshot_name-tracking-dir/snapVol1') already exists : 'true'" file="/root/CSM/csi-powerscale/service/isiService.go:460"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="the path '/ifs/.snapshot/existent_snapshot_name/data/yian/nfs_1' has already existed" file="/root/CSM/csi-powerscale/service/controller.go:510"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="begin getting export with target path '/ifs/.snapshot/existent_snapshot_name/data/yian/nfs_1' and access zone 'System' for Isilon" file="/root/CSM/csi-powerscale/service/isiService.go:775"
[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
GET /platform/2/protocols/nfs/exports/?path=%2Fifs%2F.snapshot%2Fexistent_snapshot_name%2Fdata%2Fyian%2Fnfs_1&zone=System HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:******

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: GET /platform/2/protocols/nfs/exports/?path=%2Fifs%2F.snapshot%2Fexistent_snapshot_name%2Fdata%2Fyian%2Fnfs_1&zone=System"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Transfer-Encoding: chunked
Content-Type: text/plain; charset=utf-8
Date: Thu, 15 Aug 2024 16:39:17 GMT

time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="id of the corresponding nfs export of existing volume 'snapVol1' has been resolved to '0'" file="/root/CSM/csi-powerscale/service/controller.go:555"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="begin to export volume '' with access zone 'System' in Isilon path '/ifs/.snapshot/existent_snapshot_name/data/yian/nfs_1'" file="/root/CSM/csi-powerscale/service/isiService.go:149"
[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
POST /platform/2/protocols/nfs/exports/?zone=System HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:******
Content-Type: application/json

{"paths":["/ifs/.snapshot/existent_snapshot_name/data/yian/nfs_1"]}

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: POST /platform/2/protocols/nfs/exports/?zone=System"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Content-Length: 15
Content-Type: text/plain; charset=utf-8
Date: Thu, 15 Aug 2024 16:39:17 GMT

time="2024-08-15T12:39:17-04:00" level=info clusterName=cluster1 msg="Exported volume '' successfully, id '557'" file="/root/CSM/csi-powerscale/service/isiService.go:160"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="begin getting export by id '557' with access zone 'System' for Isilon" file="/root/CSM/csi-powerscale/service/isiService.go:133"
[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
GET /platform/2/protocols/nfs/exports/557?zone=System HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:******

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: GET /platform/2/protocols/nfs/exports/557?zone=System"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Transfer-Encoding: chunked
Content-Type: text/plain; charset=utf-8
Date: Thu, 15 Aug 2024 16:39:17 GMT

time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="begin getting export by id '557' with access zone 'System' for Isilon" file="/root/CSM/csi-powerscale/service/isiService.go:133"
[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
GET /platform/2/protocols/nfs/exports/557?zone=System HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:******

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: GET /platform/2/protocols/nfs/exports/557?zone=System"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Transfer-Encoding: chunked
Content-Type: text/plain; charset=utf-8
Date: Thu, 15 Aug 2024 16:39:17 GMT

time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="Node ID 'localhost=#=#=localhost=#=#=127.0.0.1' parsed into node name 'localhost', node FQDN 'localhost' and IP address '127.0.0.1'" file="/root/CSM/csi-powerscale/common/utils/utils.go:409"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="Node ID 'localhost=#=#=localhost=#=#=127.0.0.1' parsed into node name 'localhost', node FQDN 'localhost' and IP address '127.0.0.1'" file="/root/CSM/csi-powerscale/common/utils/utils.go:409"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="ignoreUnresolvableHosts set to 'false' for cluster 'cluster1'" file="/root/CSM/csi-powerscale/service/isiService.go:592"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="entry for cluster 'cluster1' found in cluster to nodeID map" file="/root/CSM/csi-powerscale/service/isiService.go:561"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="node id to client mapping found for nodeID 'localhost=#=#=localhost=#=#=127.0.0.1' client 'localhost'" file="/root/CSM/csi-powerscale/service/isiService.go:569"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="AddExportClientNetworkIdentifierByID adding 'localhost' as client to export id '557'" file="/root/CSM/csi-powerscale/service/isiService.go:609"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="AddExportClientByID client 'localhost'" file="/root/CSM/csi-powerscale/service/isiService.go:642"
[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
GET /platform/2/protocols/nfs/exports/557?zone=System HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:******

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: GET /platform/2/protocols/nfs/exports/557?zone=System"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Transfer-Encoding: chunked
Content-Type: text/plain; charset=utf-8
Date: Thu, 15 Aug 2024 16:39:17 GMT

[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
PUT /platform/2/protocols/nfs/exports/557?zone=System HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:******
Content-Type: application/json

{"clients":["localhost"]}

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: PUT /platform/2/protocols/nfs/exports/557?zone=System"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 204 No Content
Content-Length: 0
Date: Thu, 15 Aug 2024 16:39:17 GMT

time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="updating ClusterToNodeIDMap map for cluster 'cluster1', for nodeID 'localhost=#=#=localhost=#=#=127.0.0.1' with clientToUse 'localhost'" file="/root/CSM/csi-powerscale/service/isiService.go:518"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="entry for cluster 'cluster1' found in cluster to nodeID map" file="/root/CSM/csi-powerscale/service/isiService.go:523"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="volume name at array 'volume1' and export path: /ifs/data/csi-isilon/volume1" file="/root/CSM/csi-powerscale/service/controller.go:630"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="Attributes 'map[AccessZone:System AzServiceIP:127.0.0.1 ClusterName:cluster1 ID:557 Name:volume1 Path:/ifs/data/csi-isilon/volume1 RootClientEnabled:false]'" file="/root/CSM/csi-powerscale/service/controller.go:781"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="combined volume name 'volume1' with export ID '557', access zone 'System' and cluster name 'cluster1' to form volume ID 'volume1===557===System===cluster1'" file="/root/CSM/csi-powerscale/common/utils/utils.go:327"
2024/08/15 12:39:17 volume name 'snapVol1' created
�[32mAnd�[0m �[32mI call CreateVolumeFromSnapshotMultiReader "43" "snapVol1"�[0m �[1;30m# :1 -> feature�[0m
2024/08/15 12:39:17 iCallControllerPublishVolume called with multiple-reader and vpi7125=#=#=vpi7125.a.b.com=#=#=1.1.1.1
capability.AccessType &{}
capability.AccessMode mode:MULTI_NODE_READER_ONLY
2024/08/15 12:39:17 Calling controllerPublishVolume with request volume_id:"snapVol1===43===System" node_id:"vpi7125=#=#=vpi7125.a.b.com=#=#=1.1.1.1" volume_capability:<mount:<> access_mode:<mode:MULTI_NODE_READER_ONLY > > volume_context:<key:"AccessZone" value:"" > volume_context:<key:"Path" value:"/ifs/.snapshot/snapshot-snappath" > volume_context:<key:"RootClientEnabled" value:"true" >
time="2024-08-15T12:39:17-04:00" level=info runid=1 msg="VolumeContext:" file="/root/CSM/csi-powerscale/service/controller.go:1094"
time="2024-08-15T12:39:17-04:00" level=info runid=1 msg=" [RootClientEnabled]=true" file="/root/CSM/csi-powerscale/service/controller.go:1096"
time="2024-08-15T12:39:17-04:00" level=info runid=1 msg=" [Path]=/ifs/.snapshot/snapshot-snappath" file="/root/CSM/csi-powerscale/service/controller.go:1096"
time="2024-08-15T12:39:17-04:00" level=info runid=1 msg=" [AccessZone]=" file="/root/CSM/csi-powerscale/service/controller.go:1096"
time="2024-08-15T12:39:17-04:00" level=debug runid=1 msg="volume ID 'snapVol1===43===System' parsed into volume name 'snapVol1', export ID '43', access zone 'System' and cluster name ''" file="/root/CSM/csi-powerscale/common/utils/utils.go:357"
time="2024-08-15T12:39:17-04:00" level=info runid=1 msg="Request doesn't include cluster name. Use default cluster 'cluster1'" file="/root/CSM/csi-powerscale/service/service.go:998"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="Cluster Name: cluster1" file="/root/CSM/csi-powerscale/service/controller.go:1118"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="isiSvc already initialized, skip probing" file="/root/CSM/csi-powerscale/service/service.go:376"
time="2024-08-15T12:39:17-04:00" level=info clusterName=cluster1 runid=1 msg="Volume source is snapshot" file="/root/CSM/csi-powerscale/service/controller.go:1135"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="begin getting export with target path '/ifs/.snapshot/snapshot-snappath' and access zone 'System' for Isilon" file="/root/CSM/csi-powerscale/service/isiService.go:775"
[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
GET /platform/2/protocols/nfs/exports/?path=%2Fifs%2F.snapshot%2Fsnapshot-snappath&zone=System HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:*****

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: GET /platform/2/protocols/nfs/exports/?path=%2Fifs%2F.snapshot%2Fsnapshot-snappath&zone=System"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Transfer-Encoding: chunked
Content-Type: text/plain; charset=utf-8
Date: Thu, 15 Aug 2024 16:39:17 GMT

time="2024-08-15T12:39:17-04:00" level=info clusterName=cluster1 runid=1 msg="ROVolumeFromSnapshot & rootClientEnabled is set to true, add to root clients" file="/root/CSM/csi-powerscale/service/controller.go:1203"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="Node ID 'vpi7125=#=#=vpi7125.a.b.com=#=#=1.1.1.1' parsed into node name 'vpi7125', node FQDN 'vpi7125.a.b.com' and IP address '1.1.1.1'" file="/root/CSM/csi-powerscale/common/utils/utils.go:409"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="ignoreUnresolvableHosts set to 'false' for cluster 'cluster1'" file="/root/CSM/csi-powerscale/service/isiService.go:592"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="entry for cluster 'cluster1' found in cluster to nodeID map" file="/root/CSM/csi-powerscale/service/isiService.go:561"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="node id to client mapping found for nodeID 'vpi7125=#=#=vpi7125.a.b.com=#=#=1.1.1.1' client 'vpi7125.a.b.com'" file="/root/CSM/csi-powerscale/service/isiService.go:569"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="AddExportClientNetworkIdentifierByID adding 'vpi7125.a.b.com' as client to export id '43'" file="/root/CSM/csi-powerscale/service/isiService.go:609"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="AddExportRootClientByID client 'vpi7125.a.b.com'" file="/root/CSM/csi-powerscale/service/isiService.go:653"
[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
GET /platform/2/protocols/nfs/exports/43?zone=System HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:******

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: GET /platform/2/protocols/nfs/exports/43?zone=System"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Transfer-Encoding: chunked
Content-Type: text/plain; charset=utf-8
Date: Thu, 15 Aug 2024 16:39:17 GMT

[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
PUT /platform/2/protocols/nfs/exports/557?zone=System HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:******
Content-Type: application/json

{"root_clients":["vpi7125.a.b.com"]}

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: PUT /platform/2/protocols/nfs/exports/557?zone=System"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 204 No Content
Content-Length: 0
Date: Thu, 15 Aug 2024 16:39:17 GMT

time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="updating ClusterToNodeIDMap map for cluster 'cluster1', for nodeID 'vpi7125=#=#=vpi7125.a.b.com=#=#=1.1.1.1' with clientToUse 'vpi7125.a.b.com'" file="/root/CSM/csi-powerscale/service/isiService.go:518"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="entry for cluster 'cluster1' found in cluster to nodeID map" file="/root/CSM/csi-powerscale/service/isiService.go:523"
�[32mAnd�[0m �[32mI call ControllerPublishVolume on Snapshot with name "snapVol1===43===System" and access type "multiple-reader" to "vpi7125=#=#=vpi7125.a.b.com=#=#=1.1.1.1" and path "/ifs/.snapshot/snapshot-snappath"�[0m �[1;30m# :1 -> feature�[0m
Access mode 'multiple-reader' �[32mAnd�[0m �[32ma capability with voltype "mount" access "multiple-reader"�[0m �[1;30m# :1 -> feature�[0m
�[32mAnd�[0m �[32mget Node Publish Volume Request with Volume Name "volume2===43===System===cluster1" and path "/ifs/.snapshot/snapshot-snappath"�[0m �[1;30m# :1 -> feature�[0m
Calling NodePublishVolume
time="2024-08-15T12:39:17-04:00" level=debug runid=1 msg="map 'VolumeContext':" file="/root/CSM/csi-powerscale/common/utils/utils.go:143"
time="2024-08-15T12:39:17-04:00" level=debug runid=1 msg=" [AccessZone]=''" file="/root/CSM/csi-powerscale/common/utils/utils.go:145"
time="2024-08-15T12:39:17-04:00" level=debug runid=1 msg=" [Name]='volume2===43===System===cluster1'" file="/root/CSM/csi-powerscale/common/utils/utils.go:145"
time="2024-08-15T12:39:17-04:00" level=debug runid=1 msg=" [Path]='/ifs/.snapshot/snapshot-snappath'" file="/root/CSM/csi-powerscale/common/utils/utils.go:145"
time="2024-08-15T12:39:17-04:00" level=debug runid=1 msg="volume ID 'volume2===43===System===cluster1' parsed into volume name 'volume2', export ID '43', access zone 'System' and cluster name 'cluster1'" file="/root/CSM/csi-powerscale/common/utils/utils.go:357"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="Cluster Name: cluster1" file="/root/CSM/csi-powerscale/service/node.go:99"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="isiSvc already initialized, skip probing" file="/root/CSM/csi-powerscale/service/service.go:376"
time="2024-08-15T12:39:17-04:00" level=info clusterName=cluster1 runid=1 msg="Volume source is snapshot" file="/root/CSM/csi-powerscale/service/node.go:122"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 runid=1 msg="begin getting export with target path '/ifs/.snapshot/snapshot-snappath' and access zone '' for Isilon" file="/root/CSM/csi-powerscale/service/isiService.go:775"
[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
GET /platform/2/protocols/nfs/exports/?path=%2Fifs%2F.snapshot%2Fsnapshot-snappath&zone=System HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:***

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: GET /platform/2/protocols/nfs/exports/?path=%2Fifs%2F.snapshot%2Fsnapshot-snappath&zone=System"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Transfer-Encoding: chunked
Content-Type: text/plain; charset=utf-8
Date: Thu, 15 Aug 2024 16:39:17 GMT

time="2024-08-15T12:39:17-04:00" level=info msg="Calling publishVolume" AzServiceIP= ID="volume2===43===System===cluster1" Name="volume2===43===System===cluster1" TargetPath=test/tmp/datadir
time="2024-08-15T12:39:17-04:00" level=info clusterName=cluster1 runid=1 msg="The mountOptions received are: []" file="/root/CSM/csi-powerscale/service/mount.go:62"
time="2024-08-15T12:39:17-04:00" level=info msg="Node publish volume params " AccessMode=MULTI_NODE_READER_ONLY ExportPath=":/ifs/.snapshot/snapshot-snappath" ID="volume2===43===System===cluster1" TargetPath=test/tmp/datadir
time="2024-08-15T12:39:17-04:00" level=info clusterName=cluster1 runid=1 msg="The mountOptions being used for mount are: [ro]" file="/root/CSM/csi-powerscale/service/mount.go:124"

mount source :/ifs/.snapshot/snapshot-snappath target test/tmp/datadir fstype nfs opts [ro]
mount Device :/ifs/.snapshot/snapshot-snappath Path test/tmp/datadir Source
NodePublishVolume completed successfully
�[32mAnd�[0m �[32mI call NodePublishVolume�[0m �[1;30m# :1 -> feature�[0m
�[32mAnd�[0m �[32mget Node Unpublish Volume Request for RO Snapshot "volume2===43===System===cluster1" and path "/ifs/.snapshot/snapshot-snappath"�[0m �[1;30m# :1 -> feature�[0m
Calling NodeUnPublishVolume
time="2024-08-15T12:39:17-04:00" level=debug msg="executing NodeUnpublishVolume" file="/root/CSM/csi-powerscale/service/node.go:172"
time="2024-08-15T12:39:17-04:00" level=info msg="The volume ID fetched from NodeUnPublish req is volume2===43===System===cluster1" file="/root/CSM/csi-powerscale/service/node.go:179"
time="2024-08-15T12:39:17-04:00" level=debug msg="volume ID 'volume2===43===System===cluster1' parsed into volume name 'volume2', export ID '43', access zone 'System' and cluster name 'cluster1'" file="/root/CSM/csi-powerscale/common/utils/utils.go:357"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="Cluster Name: cluster1" file="/root/CSM/csi-powerscale/service/node.go:193"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="isiSvc already initialized, skip probing" file="/root/CSM/csi-powerscale/service/service.go:376"
time="2024-08-15T12:39:17-04:00" level=info clusterName=cluster1 msg="Ephemeral volume check: false" file="/root/CSM/csi-powerscale/service/node.go:220"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="begin getting export by id '43' with access zone 'System' for Isilon" file="/root/CSM/csi-powerscale/service/isiService.go:133"
[DEBUG]
-------------------------- GOISILON HTTP REQUEST -------------------------
GET /platform/2/protocols/nfs/exports/43?zone=System HTTP/1.1
Host: 127.0.0.1:33989
Authorization: blah:****

time="2024-08-15T12:39:17-04:00" level=info msg="handler called: GET /platform/2/protocols/nfs/exports/43?zone=System"
[DEBUG]
-------------------------- GOISILON HTTP RESPONSE -------------------------
HTTP/1.1 200 OK
Transfer-Encoding: chunked
Content-Type: text/plain; charset=utf-8
Date: Thu, 15 Aug 2024 16:39:17 GMT

time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="attempting to unmount '/ifs/.snapshot/snapshot-snappath'" file="/root/CSM/csi-powerscale/service/mount.go:162"
time="2024-08-15T12:39:17-04:00" level=debug clusterName=cluster1 msg="target '/ifs/.snapshot/snapshot-snappath' does not exist" file="/root/CSM/csi-powerscale/service/mount.go:237"
2024/08/15 12:39:17 vol id volume2===43===System===cluster1
�[32mAnd�[0m �[32mI call NodeUnpublishVolume�[0m �[1;30m# :1 -> *feature�[0m
volume 'volume1'
�[32mThen�[0m �[32ma valid CreateVolumeResponse is returned�[0m �[1;30m# :1 -> *feature�[0m

363 scenarios (�[32m363 passed�[0m)
1915 steps (�[32m1915 passed�[0m)
1m43.848557135s
godog finished
=== RUN TestMkdirCreateDir
time="2024-08-15T12:39:17-04:00" level=debug msg="created directory" file="/root/CSM/csi-powerscale/service/mount.go:201"
--- PASS: TestMkdirCreateDir (0.00s)
=== RUN TestMkdirExistingDir
--- PASS: TestMkdirExistingDir (0.00s)
=== RUN TestMkdirExistingFile
--- PASS: TestMkdirExistingFile (0.00s)
PASS
coverage: 79.5% of statements
status 0
ok github.com/dell/csi-isilon/v2/service 104.067s coverage: 79.5% of statements
=== RUN TestRewriteRequestIDInterceptor_RequestIDExist
--- PASS: TestRewriteRequestIDInterceptor_RequestIDExist (0.00s)
=== RUN TestNewCustomSerialLock
time="2024-08-15T12:37:46-04:00" level=warning msg="env var not found: CSI_RETRIEVER_ENDPOINT"
=== RUN TestNewCustomSerialLock/NodeStage_for_same_volume_concurrent_call
start sleep
stop sleep
=== RUN TestNewCustomSerialLock/NodeUnstage_for_same_volume_concurrent_call
start sleep
stop sleep
=== RUN TestNewCustomSerialLock/NodeUnstage_for_different_volumes
start sleep
start sleep
stop sleep
stop sleep
=== RUN TestNewCustomSerialLock/NodeStage_for_different_volumes
start sleep
start sleep
stop sleep
stop sleep
=== RUN TestNewCustomSerialLock/NodePublish_for_same_volume_concurrent_call
start sleep
stop sleep
=== RUN TestNewCustomSerialLock/NodePublish_and_NodeStage_for_same_volume_concurrent_call
start sleep
stop sleep
=== RUN TestNewCustomSerialLock/CreateVolume_for_same_volume_concurrent_call
start sleep
stop sleep
=== RUN TestNewCustomSerialLock/CreateVolume_for_different_volumes
start sleep
start sleep
stop sleep
stop sleep
--- PASS: TestNewCustomSerialLock (2.71s)
--- PASS: TestNewCustomSerialLock/NodeStage_for_same_volume_concurrent_call (0.30s)
--- PASS: TestNewCustomSerialLock/NodeUnstage_for_same_volume_concurrent_call (0.30s)
--- PASS: TestNewCustomSerialLock/NodeUnstage_for_different_volumes (0.40s)
--- PASS: TestNewCustomSerialLock/NodeStage_for_different_volumes (0.40s)
--- PASS: TestNewCustomSerialLock/NodePublish_for_same_volume_concurrent_call (0.30s)
--- PASS: TestNewCustomSerialLock/NodePublish_and_NodeStage_for_same_volume_concurrent_call (0.30s)
--- PASS: TestNewCustomSerialLock/CreateVolume_for_same_volume_concurrent_call (0.30s)
--- PASS: TestNewCustomSerialLock/CreateVolume_for_different_volumes (0.40s)
PASS
coverage: 66.2% of statements
ok github.com/dell/csi-isilon/v2/service/interceptor 2.816s coverage: 66.2% of statements

…exported at raay to k8s caller

atye · 2024-08-14T18:09:46Z

Any unit test that can be added?

shaynafinocchiaro · 2024-08-14T18:43:34Z

Linting check has failed.

gallacher

Please provide the test results and address the lint issues.

Test result has IPs addresses

gallacher

Please include test results that have been sanitized so show that show results of all tests passing. Can you also show the code coverage numbers in relation to what they were before this code change? Have you maintained the coverage numbers or are more tests required?

alikdell · 2024-08-15T17:47:39Z

Please include test results that have been sanitized so show that show results of all tests passing. Can you also show the code coverage numbers in relation to what they were before this code change? Have you maintained the coverage numbers or are more tests required?

Code that I have added do not need new unit test. It is part of volume create code, only thing we are doing is grab the return export path and extract volume name, before my changes we were returning driver generated volume name not actual name at array. Code coverage is same no changes, as code change is minimal and has unit test code to cover this use case already.

answer provided

alikdell added 8 commits July 3, 2024 17:08

service/controller.go

0ab0d44

Changes made to return array volume name after volume is created and …

599fd43

…exported at raay to k8s caller

getCreateVolumeResponse return the actual export and volume name

5fc250a

Merge branch 'main' into auth-tenant-prefix

d66978e

Remove test and debug code

488465d

Remove test and debug code

9da253d

Remove test and debug code

c94d16e

Fix unit test failure

e5223e6

atye reviewed Aug 14, 2024

View reviewed changes

Comment thread service/controller.go Outdated

atye reviewed Aug 14, 2024

View reviewed changes

Comment thread service/controller.go Outdated

PR review edit

2228d4e

atye previously approved these changes Aug 14, 2024

View reviewed changes

linting fixes

ae7ac15

alikdell dismissed atye’s stale review via ae7ac15 August 14, 2024 20:26

gallacher previously requested changes Aug 15, 2024

View reviewed changes

alikdell added 10 commits August 15, 2024 09:12

fix linting error

e98f269

fix linting error

1872d93

fix linting error

c850e78

fix linting error

ffad4da

fix linting error

32b8940

fix linting error

9c69c64

fix linting error

988ec9a

fix linting error

405bfa8

fix linting error

41c7fd5

fix linting error

75fee7b

gallacher previously requested changes Aug 15, 2024

View reviewed changes

fix linting error

580005f

shaynafinocchiaro reviewed Aug 15, 2024

View reviewed changes

Comment thread service/features/node_publish_unpublish.feature

Comment thread service/controller.go

shaynafinocchiaro approved these changes Aug 15, 2024

View reviewed changes

atye approved these changes Aug 19, 2024

View reviewed changes

alikdell merged commit 612505e into main Aug 19, 2024

alikdell deleted the auth-tenant-prefix branch August 19, 2024 16:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use volume name that got created at array is return to caller#273

Use volume name that got created at array is return to caller#273
alikdell merged 21 commits into
mainfrom
auth-tenant-prefix

alikdell commented Aug 14, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

atye commented Aug 14, 2024

Uh oh!

shaynafinocchiaro commented Aug 14, 2024

Uh oh!

gallacher left a comment

Uh oh!

gallacher left a comment

Uh oh!

alikdell commented Aug 15, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

alikdell commented Aug 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

GitHub Issues

Checklist:

How Has This Been Tested?

Uh oh!

Uh oh!

Uh oh!

atye commented Aug 14, 2024

Uh oh!

shaynafinocchiaro commented Aug 14, 2024

Uh oh!

gallacher left a comment

Choose a reason for hiding this comment

Uh oh!

gallacher left a comment

Choose a reason for hiding this comment

Uh oh!

alikdell commented Aug 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alikdell commented Aug 14, 2024 •

edited

Loading

alikdell commented Aug 15, 2024 •

edited

Loading