Skip to content

Add non GA version check#266

Merged
bharathsreekanth merged 2 commits into
mainfrom
sreekb/krv-25257
Jun 24, 2024
Merged

Add non GA version check#266
bharathsreekanth merged 2 commits into
mainfrom
sreekb/krv-25257

Conversation

@bharathsreekanth

@bharathsreekanth bharathsreekanth commented Jun 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Update Helm installer to detect unreleased (alpha/beta) Kubernetes releases and prompt the user for acknowledgement before proceeding with installation.

| GitHub Issue # |
| (https://github.com/dell/csm/issues/1325) |

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested the regex outside with varying combinations to ensure that it returns what is expected.
  • Tested by hardcoding different versions of the strings and attempting the install to ensure alpha/beta versions ask for user acknowledgement.

@bharathsreekanth bharathsreekanth marked this pull request as ready for review June 21, 2024 14:14
tdawe
tdawe reviewed Jun 21, 2024
View reviewed changes
Comment thread dell-csi-helm-installer/verify.sh
@bharathsreekanth bharathsreekanth requested a review from tdawe June 21, 2024 16:58
@bharathsreekanth bharathsreekanth merged commit 5716adc into main Jun 24, 2024
@bharathsreekanth bharathsreekanth deleted the sreekb/krv-25257 branch June 24, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdawe tdawe tdawe approved these changes

@atye atye Awaiting requested review from atye

@bogdanNovikovDell bogdanNovikovDell Awaiting requested review from bogdanNovikovDell

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@chimanjain chimanjain Awaiting requested review from chimanjain

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@donatwork donatwork Awaiting requested review from donatwork

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

@Leonard-Dell Leonard-Dell Awaiting requested review from Leonard-Dell

@mdutka-dell mdutka-dell Awaiting requested review from mdutka-dell

@meggm meggm Awaiting requested review from meggm

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

+1 more reviewer

@nitesh3108 nitesh3108 nitesh3108 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bharathsreekanth @tdawe @nitesh3108