Skip to content

fix: parse normalized snapshotID#237

Merged
mdutka-dell merged 3 commits into
release-2.10.0from
delete_snapshot_id_parsing
Feb 16, 2024
Merged

fix: parse normalized snapshotID#237
mdutka-dell merged 3 commits into
release-2.10.0from
delete_snapshot_id_parsing

Conversation

@mdutka-dell

@mdutka-dell mdutka-dell commented Jan 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • bug fixing connected with parsing normalized snapshotID
  • writing additional unit tests

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1104

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
1) Package csi-powerscale/service
363 scenarios (363 passed)
1915 steps (1915 passed)
1m40.302991248s
godog finished
=== RUN   TestMkdirCreateDir
time="2024-02-14T05:21:45-05:00" level=debug   msg="created directory" file="/home/gosia/repos/csi-powerscale/service/mount.go:201"
--- PASS: TestMkdirCreateDir (0.00s)
=== RUN   TestMkdirExistingDir
--- PASS: TestMkdirExistingDir (0.00s)
=== RUN   TestMkdirExistingFile
--- PASS: TestMkdirExistingFile (0.00s)
PASS
coverage: 79.2% of statements
status 0
ok      github.com/dell/csi-isilon/v2/service   100.421s

2) Package csi-powerscale/common/utils
PASS
coverage: 45.9% of statements
ok      github.com/dell/csi-isilon/v2/common/utils      0.609s

gallacher
gallacher suggested changes Jan 31, 2024
View reviewed changes

@gallacher gallacher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link this PR to a GitHub issue. Thanks.

@mdutka-dell mdutka-dell requested a review from gallacher February 1, 2024 09:25
@mdutka-dell mdutka-dell changed the base branch from main to release-2.10.0 February 2, 2024 12:45
cbartoszDell
cbartoszDell reviewed Feb 5, 2024
View reviewed changes
Comment thread common/utils/utils_test.go
cbartoszDell
cbartoszDell approved these changes Feb 6, 2024
View reviewed changes

@cbartoszDell cbartoszDell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

shefali-malhotra
shefali-malhotra approved these changes Feb 16, 2024
View reviewed changes

@shefali-malhotra shefali-malhotra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdutka-dell mdutka-dell merged commit d55a851 into release-2.10.0 Feb 16, 2024
@mdutka-dell mdutka-dell deleted the delete_snapshot_id_parsing branch February 16, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chimanjain chimanjain Awaiting requested review from chimanjain

@meggm meggm Awaiting requested review from meggm

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108

@prablr79 prablr79 Awaiting requested review from prablr79

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@donatwork donatwork Awaiting requested review from donatwork

@adamginna-dell adamginna-dell Awaiting requested review from adamginna-dell

@bogdanNovikovDell bogdanNovikovDell Awaiting requested review from bogdanNovikovDell

@Leonard-Dell Leonard-Dell Awaiting requested review from Leonard-Dell

@mareksuski-dell mareksuski-dell Awaiting requested review from mareksuski-dell

@gallacher gallacher Awaiting requested review from gallacher

3 more reviewers

@bpjain2004 bpjain2004 bpjain2004 approved these changes

@shefali-malhotra shefali-malhotra shefali-malhotra approved these changes

@cbartoszDell cbartoszDell cbartoszDell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mdutka-dell @gallacher @bpjain2004 @shefali-malhotra @cbartoszDell