Skip to content

Updates DisconnectVolume to correctly fail and clean up the sd disks.…#592

Merged
kumarkgosa merged 1 commit into
mainfrom
bugfix/disconnectVolume
Sep 9, 2025
Merged

Updates DisconnectVolume to correctly fail and clean up the sd disks.…#592
kumarkgosa merged 1 commit into
mainfrom
bugfix/disconnectVolume

Conversation

@kumarkgosa

@kumarkgosa kumarkgosa commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

Description

A few sentences describing the overall goals of the pull request's commits.

  • Update the disconnectVolume to fail on failed deletion of underlying devices.
  • Dont use symlink or dm paths for wwn existence verification on the node.
  • Changed the cleanup to use new disconnectVolumebyWWN call. It handles the deletion of device better.
  • The fix only impact FC protocol, other protocol follows the old disconnectVolume call.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/2010

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Validated the fix on FC with multipath for provisioning, expansion.
  • Validated the fix on iSCSI with multipath provisioning, expansion.

shanmydell
shanmydell previously approved these changes Sep 9, 2025

@shanmydell shanmydell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, validated the internal logs

@shanmydell

Copy link
Copy Markdown
Contributor

@delldubey could you sign the commit

bpjain2004
bpjain2004 previously approved these changes Sep 9, 2025
@delldubey delldubey dismissed stale reviews from bpjain2004 and shanmydell via 4e41e62 September 9, 2025 16:34
@delldubey delldubey force-pushed the bugfix/disconnectVolume branch from 0a7f814 to 4e41e62 Compare September 9, 2025 16:34
bpjain2004
bpjain2004 previously approved these changes Sep 9, 2025
@github-actions

github-actions Bot commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powermax/service 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powermax/service/interfaces.go 0.00% (ø) 0 0 0
github.com/dell/csi-powermax/service/node.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powermax/service/gobrick_mock_test.go

@kumarkgosa kumarkgosa merged commit c38e4d6 into main Sep 9, 2025
6 checks passed
@kumarkgosa kumarkgosa deleted the bugfix/disconnectVolume branch September 9, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants