Skip to content

Support nvme-cli 2.11 (OCP 4.19, RHEL9.6, RCOS 9.6)#551

Merged
donatwork merged 1 commit into
mainfrom
usr/dkhan/nvme-211-enhancements
Jun 24, 2025
Merged

Support nvme-cli 2.11 (OCP 4.19, RHEL9.6, RCOS 9.6)#551
donatwork merged 1 commit into
mainfrom
usr/dkhan/nvme-211-enhancements

Conversation

@donatwork

@donatwork donatwork commented Jun 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Support nvme-cli 2.11 which uses a different format in the nvme list -o json results. This release is used in OCP 4.19 and RHEL/RCOS 9.6 releases.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1896

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

  • []
  • []

@github-actions

github-actions Bot commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powermax/service 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powermax/service/node.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@donatwork donatwork marked this pull request as ready for review June 24, 2025 02:38
@donatwork donatwork merged commit e46911b into main Jun 24, 2025
6 checks passed
@donatwork donatwork deleted the usr/dkhan/nvme-211-enhancements branch June 24, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

2 more reviewers

@abhi16394 abhi16394 abhi16394 approved these changes

@santhoshatdell santhoshatdell santhoshatdell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@donatwork @abhi16394 @santhoshatdell