Skip to content

Ut fix#546

Merged
donatwork merged 2 commits into
mainfrom
ut-fix
May 29, 2025
Merged

Ut fix#546
donatwork merged 2 commits into
mainfrom
ut-fix

Conversation

@donatwork

@donatwork donatwork commented May 29, 2025

Copy link
Copy Markdown
Contributor

Description

Fix unit test. Valid outcomes can change based on Go's nondeterministic map iteration.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1748
https://github.com/dell/csm/issues/1896

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

@github-actions

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powermax/service 0.00% (ø)

Coverage by file

Changed unit test files

  • github.com/dell/csi-powermax/service/controller_test.go

@donatwork donatwork requested a review from atye May 29, 2025 19:41
@donatwork donatwork merged commit 3ab5184 into main May 29, 2025
6 checks passed
@donatwork donatwork deleted the ut-fix branch May 29, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants