Skip to content

Deprecate Powermax Array Configmap#511

Merged
sakshi-garg1 merged 4 commits into
mainfrom
deprecate_array_configmap
Apr 7, 2025
Merged

Deprecate Powermax Array Configmap#511
sakshi-garg1 merged 4 commits into
mainfrom
deprecate_array_configmap

Conversation

@sakshi-garg1

@sakshi-garg1 sakshi-garg1 commented Apr 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adding comment to deprecate powermax array configmap

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1776

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How this has been tested?

  • Helm installation by manually deleting powermax-array-config.yaml from helm-charts/charts/csi-powermax/templates folder and driver installed successfully
  • Operator installation by not creating powermax-array-config.yaml and providing values in sample yaml and driver installed successfully
  • Respective scenarios for upgrade as well.
  • Tested with mount creds functionality also.

@sakshi-garg1 sakshi-garg1 self-assigned this Apr 3, 2025
@sakshi-garg1 sakshi-garg1 changed the title Deprecate Powermx Array Configmap Deprecate Powermax Array Configmap Apr 3, 2025
AkshaySainiDell
AkshaySainiDell previously approved these changes Apr 3, 2025
View reviewed changes
AronAtDell
AronAtDell reviewed Apr 3, 2025
View reviewed changes
Comment thread samples/configmap/powermax-array-config.yaml Outdated
karthikk92
karthikk92 previously approved these changes Apr 4, 2025
View reviewed changes
rishabhatdell
rishabhatdell previously approved these changes Apr 4, 2025
View reviewed changes
@alikdell

alikdell commented Apr 4, 2025

Copy link
Copy Markdown
Collaborator

What happen to upgrade scenario, please provide more description?

@sakshi-garg1

sakshi-garg1 commented Apr 4, 2025

Copy link
Copy Markdown
Contributor Author

What happen to upgrade scenario, please provide more description?

In case of helm update, there will be 2 scenarios:

  • when powermax-array-config is created - this follow normal upgrade no changes required
  • when powermax-array-config is not created- since this is deprecation notice and powermax-array-config already exists, I manually deleted powermax-array-config.yaml from helm-charts/charts/csi-powermax/templates folder. ran install command with --upgrade flag, the driver was upgraded with values which are already present in values.yaml of helm.

In case of operator update, there will be 2 scenarios:

  • when powermax-array-config is created - this follow normal upgrade no changes required
  • when powermax-array-config is not created- user needs to give values in sample yamls of operator
    You can check #ECS01A-210 where I have captured details of testing upgrade in detail.

@sakshi-garg1 sakshi-garg1 merged commit 32fb1d5 into main Apr 7, 2025
@sakshi-garg1 sakshi-garg1 deleted the deprecate_array_configmap branch April 7, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AronAtDell AronAtDell AronAtDell left review comments

@sharmilarama sharmilarama sharmilarama left review comments

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@donatwork donatwork Awaiting requested review from donatwork

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@falfaroc falfaroc Awaiting requested review from falfaroc

@lukeatdell lukeatdell Awaiting requested review from lukeatdell

+4 more reviewers

@karthikk92 karthikk92 karthikk92 approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@rishabhatdell rishabhatdell rishabhatdell left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sakshi-garg1 sakshi-garg1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@sakshi-garg1 @alikdell @AronAtDell @sharmilarama @karthikk92 @AkshaySainiDell @suryagupta4 @rishabhatdell