Skip to content

Filter SCSI FC ports during PG creation#510

Merged
AkshaySainiDell merged 8 commits into
mainfrom
bugfix-1826-fc-port-group
Apr 7, 2025
Merged

Filter SCSI FC ports during PG creation#510
AkshaySainiDell merged 8 commits into
mainfrom
bugfix-1826-fc-port-group

Conversation

@AkshaySainiDell

@AkshaySainiDell AkshaySainiDell commented Apr 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR addresses an issue where the PowerMax CSI driver attempts to create port groups containing both Fibre Channel (FC) and NVMe/FC ports, leading to failures due to protocol mismatches. The driver now excludes NVMe/FC ports when creating port groups, preventing protocol mismatch issues and ensuring smooth operation.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1826

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Installed driver on a FC cluster and ran cert-csi scale test for powermax-fc storage class. Masking view and port group were deleted before running the test.

@AkshaySainiDell AkshaySainiDell marked this pull request as ready for review April 4, 2025 08:55
@alikdell

alikdell commented Apr 4, 2025

Copy link
Copy Markdown
Collaborator

Issue are seen where we have mix of protcols. Can you describe how that scenario being tested here. Your test description do not explicitly list that scenario.

@AkshaySainiDell

AkshaySainiDell commented Apr 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Issue are seen where we have mix of protcols. Can you describe how that scenario being tested here. Your test description do not explicitly list that scenario.

Correct, the issue is observed when at least one initiator is logged into an NVMe/FC port.
Even though driver does not support NVMe/FC, it does not filter out NVMe/FC ports during CotrollerPublishVolume. It simply fetches all the initiator ports and proceeds with PortGroup selection/creation process.

This fix adds another check to filter only the ISCSI_FC ports and proceed with PortGroup selection/creation process.

The fix was validated on FC environment, after deleting the masking view, storage group and port group from UI (this step ensures that we enter the PG selection/creation process) and then running cert-csi scale test.

donatwork
donatwork previously approved these changes Apr 4, 2025
View reviewed changes

@donatwork donatwork left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to reproduce the initial error? Have you checked if we need to test port types in other places?

Comment thread service/controller.go Outdated
santhoshatdell
santhoshatdell reviewed Apr 4, 2025
View reviewed changes
Comment thread service/controller.go
@github-actions

github-actions Bot commented Apr 7, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powermax/pkg/symmetrix/mocks 0.00% (ø)
github.com/dell/csi-powermax/service 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powermax/pkg/symmetrix/mocks/pmaxclient.go 0.00% (ø) 0 0 0
github.com/dell/csi-powermax/service/controller.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@AkshaySainiDell AkshaySainiDell merged commit 6ea25b0 into main Apr 7, 2025
@AkshaySainiDell AkshaySainiDell deleted the bugfix-1826-fc-port-group branch April 7, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

3 more reviewers

@donatwork donatwork donatwork approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@santhoshatdell santhoshatdell santhoshatdell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AkshaySainiDell @alikdell @donatwork @suryagupta4 @santhoshatdell