Updated the snapshot size#491
Merged
Merged
Conversation
rishabhatdell
previously approved these changes
Mar 18, 2025
Contributor
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
AkshaySainiDell
approved these changes
Mar 18, 2025
|
can we get coverage here ? |
kumarp20
approved these changes
Mar 18, 2025
SinuChacko
approved these changes
Mar 18, 2025
Contributor
Author
|
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the SizeBytes field in the csi.Snapshot structure to use the volume capacity in gigabytes (vol.CapacityGB) instead of the previous calculation based on cylinder size. This change ensures that the snapshot size is accurately represented in bytes.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Ran Cert-csi
Replication Suite
SnapShot suite
CapcityTracking Suite
