MultiAZ NodeGetInfo changes#488
Merged
Merged
Conversation
and CreateVolume (as necessary) to pick up StorageArrays Labels and Parameters if provided within the new powermax secret.
getStorageArrays() func created and moved the code out of beforeServe.
…ultiaz-nodegetinfo
…ultiaz-nodegetinfo
donatwork
reviewed
Mar 17, 2025
Contributor
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
donatwork
reviewed
Mar 18, 2025
anathoodell
reviewed
Mar 18, 2025
| arrayLabels := arrayConfig.Labels | ||
| nodeLabels, err := s.k8sUtils.GetNodeLabels(s.opts.NodeFullName) | ||
| if err != nil { | ||
| log.Infof("failed to get Node Labels with error '%s'", err.Error()) |
Contributor
There was a problem hiding this comment.
Should this be an Error log?
Contributor
Author
There was a problem hiding this comment.
Good question. I followed the same way as it is implemented in NodeGetInfo. It is an Info log there. Do we want both places to show an error? We don't interrupt after this, so for me it looks more like an Info, but logically it is an error
anathoodell
approved these changes
Mar 18, 2025
donatwork
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds changes to
NodeGetInfoto update node topology according to zone labels from the secretGitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration