Adding Labels and Parameter fields to StorageArray configuration as part of new secret.#482
Merged
Merged
Conversation
Contributor
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
donatwork
reviewed
Mar 10, 2025
donatwork
approved these changes
Mar 11, 2025
donatwork
left a comment
Contributor
There was a problem hiding this comment.
Please add constants for the new parameters in the next PR.
Contributor
Author
will do. |
EvgenyUglov
approved these changes
Mar 11, 2025
ChristianAtDell
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding Labels and Parameters fields to the StorageArray. Making this available in proxy config for use elsewhere.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
Note: Integration tests are not passing and there is an ongoing defect to address this.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration