Skip to content

Metro: Set default value for replication prefixes#417

Merged
santhoshatdell merged 2 commits into
mainfrom
metro-rep-prefix-fix
Jan 22, 2025
Merged

Metro: Set default value for replication prefixes#417
santhoshatdell merged 2 commits into
mainfrom
metro-rep-prefix-fix

Conversation

@santhoshatdell

@santhoshatdell santhoshatdell commented Jan 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Set default values for replication prefix in the driver since replicator sidecar is not needed for Metro feature.
With this, the driver will not fail the Metro request irrespective of the deployment method used.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1711

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation [TBA - revert Doc notes]
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Metro volume was created successfully and then deleted, with just the driver installed without the replication module or the replicator sidecar.

[root@koc1-bastion-10-247-96-100 powermax_309_836]# k get pv | grep metro
csivol-d642603e51   10487040Ki   RWO            Delete           Bound         default/my-pvc  
                                                 powermax-metro              <unset>                          13m
[root@koc1-bastion-10-247-96-100 powermax_309_836]# k get pvc | grep metro
my-pvc                        Bound         csivol-d642603e51   10487040Ki   RWO            powermax-metro              <unset>                 13m

[root@koc1-bastion-10-247-96-100 powermax_309_836]# k get pod | grep my-pod
my-pod                       1/1     Running     0               13m

@santhoshatdell santhoshatdell changed the title Metro: Set default value for replication prefixes [WIP] Metro: Set default value for replication prefixes Jan 17, 2025
@santhoshatdell santhoshatdell mentioned this pull request Jan 17, 2025
Closed
9 tasks
@santhoshatdell santhoshatdell changed the title [WIP] Metro: Set default value for replication prefixes Metro: Set default value for replication prefixes Jan 21, 2025
@santhoshatdell santhoshatdell marked this pull request as ready for review January 21, 2025 22:05
@santhoshatdell santhoshatdell mentioned this pull request Jan 22, 2025
Merged
5 tasks
@santhoshatdell santhoshatdell merged commit 1c59cc1 into main Jan 22, 2025
@santhoshatdell santhoshatdell deleted the metro-rep-prefix-fix branch January 22, 2025 17:54
@niranjan-n1 niranjan-n1 mentioned this pull request May 15, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

3 more reviewers

@donatwork donatwork donatwork approved these changes

@gallacher gallacher gallacher approved these changes

@niranjan-n1 niranjan-n1 niranjan-n1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@santhoshatdell @donatwork @gallacher @niranjan-n1