Skip to content

Add preflight required labels.#403

Merged
suryagupta4 merged 3 commits into
mainfrom
usr/dkhan/preflight-update
Jan 9, 2025
Merged

Add preflight required labels.#403
suryagupta4 merged 3 commits into
mainfrom
usr/dkhan/preflight-update

Conversation

@donatwork

@donatwork donatwork commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

Description

Added the required labels to the image container so that it can pass preflight checks.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1667

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Built images. Docker inspect show:

      "Labels": {
           "architecture": "x86_64",
           "build-date": "2024-08-27T19:24:54",
           "com.redhat.component": "ubi9-micro-container",
           "com.redhat.license_terms": "https://www.redhat.com/en/about/red-hat-end-user-license-agreements#UBI",
           "description": "CSI Driver for provisioning persistent storage from Dell EMC PowerMax",
           "distribution-scope": "public",
           "io.buildah.version": "1.29.4",
           "io.k8s.description": "Very small image which doesn't install the package manager.",
           "io.k8s.display-name": "Ubi9-micro",
           "io.openshift.expose-services": "",
           "license": "Apache-2.0",
           "maintainer": "Dell Technologies",
           "name": "csi-powermax",
           "release": "1.13.0",
           "summary": "CSI Driver for Dell EMC PowerMax",
           "url": "https://access.redhat.com/containers/#/registry.access.redhat.com/ubi9/ubi-micro/images/9.4-15",
           "vcs-ref": "cd5996c9b8b99b546584696465f8f39ec682078c",
           "vcs-type": "git",
           "vendor": "Dell Technologies",
           "version": "2.13.0"
      },
      
     "Labels": {
           "architecture": "x86_64",
           "build-date": "2024-08-27T19:24:54",
           "com.redhat.component": "ubi9-micro-container",
           "com.redhat.license_terms": "https://www.redhat.com/en/about/red-hat-end-user-license-agreements#UBI",
           "description": "CSI PowerMax Reverse Proxy which helps manage connections with Unisphere for PowerMax",
           "distribution-scope": "public",
           "io.buildah.version": "1.29.4",
           "io.k8s.description": "Very small image which doesn't install the package manager.",
           "io.k8s.display-name": "Ubi9-micro",
           "io.openshift.expose-services": "",
           "license": "Apache-2.0",
           "maintainer": "Dell Technologies",
           "name": "csipowermax-reverseproxy",
           "release": "1.13.0",
           "summary": "CSI PowerMax Reverse Proxy",
           "url": "https://access.redhat.com/containers/#/registry.access.redhat.com/ubi9/ubi-micro/images/9.4-15",
           "vcs-ref": "cd5996c9b8b99b546584696465f8f39ec682078c",
           "vcs-type": "git",
           "vendor": "Dell Technologies",
           "version": "2.12.0"
      },

@suryagupta4 suryagupta4 merged commit 7d41197 into main Jan 9, 2025
@suryagupta4 suryagupta4 deleted the usr/dkhan/preflight-update branch January 9, 2025 05:36
@santhoshatdell santhoshatdell mentioned this pull request Jan 9, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alikdell alikdell alikdell approved these changes

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

+2 more reviewers

@bpjain2004 bpjain2004 bpjain2004 approved these changes

@santhoshatdell santhoshatdell santhoshatdell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@donatwork @alikdell @bpjain2004 @santhoshatdell @suryagupta4