Clarify which secret is for which unisphere in reverseproxy configmap#366
Merged
Conversation
5 tasks
mbasha-dell
approved these changes
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The sample secret names used in the sample reverseproxy configmap yaml are unclear. This PR makes it clear which endpoint each secret is for. There is an accompanying doc PR for this clarification here: dell/csm-docs#1370
Additionally, a few unrelated variable names were changed to comply with linting, and I added a unit test to cover the code where I changed the variable name.
GitHub Issues
Checklist:
How Has This Been Tested?
Ran unit tests for both driver and reverseproxy. No integration tests run because these changes are not touched by integration tests (there are no code changes).