Skip to content

Update integration test README#354

Merged
jooseppi-luna merged 1 commit into
mainfrom
integration-test-readme-update
Oct 29, 2024
Merged

Update integration test README#354
jooseppi-luna merged 1 commit into
mainfrom
integration-test-readme-update

Conversation

@jooseppi-luna

@jooseppi-luna jooseppi-luna commented Oct 29, 2024

Copy link
Copy Markdown
Contributor

Description

Update integration test readme with the following:

  1. Change the file from README to README.md so that markdown works.
  2. Update the steps for running the integration test to ones that actually work.
  3. Add a note on replication test cases that are not currently working due to issues in the tests themselves.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1519

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

This is only a README change. Tested the steps in the README and confirmed that I am able to run the integration tests.

@mjsdell mjsdell self-requested a review October 29, 2024 19:26

@mjsdell mjsdell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abhi16394 abhi16394 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jooseppi-luna jooseppi-luna merged commit 3bd9e60 into main Oct 29, 2024
@jooseppi-luna jooseppi-luna deleted the integration-test-readme-update branch October 29, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants