Fixed Defect in service.go#331
Merged
Merged
Conversation
Contributor
Author
|
|
gallacher
suggested changes
Sep 27, 2024
gallacher
left a comment
Contributor
There was a problem hiding this comment.
Please add unit tests to test these new lines of code. Also, the summary line indicates you're fixing a defect but I don't think there is a defect for this? This is addressing technical debt is it not?
Collaborator
|
@daniyaliqbal2024 - GitHub mapping was wrong. Can you create the defect in github and map it. |
Contributor
Author
|
|
Contributor
Author
|
|
donatwork
approved these changes
Oct 3, 2024
donatwork
left a comment
Contributor
There was a problem hiding this comment.
I viewed the code coverage and it is an adequate fix for the problem. The cost of testing that the error is actually logged is something that we could do but it is costly to change in the current code.
gallacher
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introducing a error check for setting array related data to envs in csi-powermax
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Ran sucessful gosec./... test and make unit-test with screenshots below