Skip to content

Added make target to build without cache#326

Merged
francis-nijay merged 5 commits into
mainfrom
build-no-cache
Sep 17, 2024
Merged

Added make target to build without cache#326
francis-nijay merged 5 commits into
mainfrom
build-no-cache

Conversation

@francis-nijay

@francis-nijay francis-nijay commented Sep 17, 2024 •
edited by AkshaySainiDell
Loading

Copy link
Copy Markdown
Collaborator

Description

Image build job fails because of no space left on the build machine. This is caused by overlay images created during the build process

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1448

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested build and there are no overlay containers left mounted on the build machine

@francis-nijay

francis-nijay commented Sep 17, 2024

Copy link
Copy Markdown
Collaborator Author

image
Overlay containers are not present after the build is completed

adarsh-dell
adarsh-dell previously approved these changes Sep 17, 2024
View reviewed changes

@adarsh-dell adarsh-dell left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

donatwork
donatwork previously approved these changes Sep 17, 2024
View reviewed changes
gallacher
gallacher previously approved these changes Sep 17, 2024
View reviewed changes
@francis-nijay francis-nijay merged commit 66d3293 into main Sep 17, 2024
@anandrajak1 anandrajak1 deleted the build-no-cache branch October 17, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@gallacher gallacher Awaiting requested review from gallacher

3 more reviewers

@donatwork donatwork donatwork approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@adarsh-dell adarsh-dell adarsh-dell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@francis-nijay @donatwork @gallacher @AkshaySainiDell @adarsh-dell