fix: correct Metal quickstart docs for selectorless services#173
Merged
fix: correct Metal quickstart docs for selectorless services#173
Conversation
Metal services are selectorless (no pods on K8s), so kubectl port-forward does not work. Updated README to show in-cluster DNS access and a temporary curl pod approach instead. Also fix missing trailing newline in registry_test. Signed-off-by: Christopher Maher <chris@mahercode.io>
6446dbd to
735857d
Compare
Member
Author
|
Hey @matiasinsaurralde , do you mind checking this to see if that makes sense and works for you before we close this one out? |
Contributor
|
This works @Defilan, thanks! |
This was referenced Feb 25, 2026
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #166
kubectl port-forwarddoes not workpkg/agent/registry_test.goTest plan
Signed-off-by: Christopher Maher chris@mahercode.io