feat(agent): add --host-ip flag for remote K8s cluster support#155
Merged
feat(agent): add --host-ip flag for remote K8s cluster support#155
Conversation
Add a --host-ip flag to the Metal Agent that allows specifying an explicit IP address to register in Kubernetes endpoints. This enables running the Metal Agent on a separate machine from the K8s cluster (e.g. Mac Studio with Metal GPU connected to a remote cluster over Tailscale). When omitted, the existing auto-detection behavior via host.minikube.internal / host.docker.internal is preserved. Closes #154 Signed-off-by: Christopher Maher <chris@mahercode.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--host-ipflag to the Metal Agent CLI for specifying an explicit IP address to register in Kubernetes endpointshost.minikube.internal/host.docker.internalresolveHostIPbehavior and explicit host IP endpoint registrationTest plan
go test ./pkg/agent/ -v)TestResolveHostIP_Explicitverifies explicit IP is returnedTestResolveHostIP_AutoDetectverifies fallback when emptyTestRegisterEndpoint_ExplicitHostIPverifies the IP appears in created EndpointsGOOS=darwin GOARCH=arm64 go build ./cmd/metal-agentcompiles cleanlyCloses #154