refactor: descope initializer#69
Merged
0xDiscotech merged 2 commits intosc-feat/revenue-sharingfrom Oct 13, 2025
Merged
Conversation
0xiamflux
reviewed
Oct 13, 2025
| storage variable was set. This allows the [`FeeVaultInitializer`](./fee-vault-initializer.md) to set | ||
| legacy (immutable) values when deploying the new fee vault implementation and enables the `ProxyAdmin.owner` | ||
| to override what is returned by the getters once the new configuration has been set. | ||
| Legacy getters are preserved, but default to the newly added storage variables now. |
There was a problem hiding this comment.
Not sure if this is clear enough. Maybe also mention the deprecation instead of just pointing to use those variables.
agusduha
approved these changes
Oct 13, 2025
0xiamflux
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLOSES OPT-1213