chore: fee splitter sync#598
Merged
0xDiscotech merged 17 commits intosc-feat/fee-splitter-systemfrom Sep 23, 2025
Merged
Conversation
* start * DeployOwnership scripts update * cleanup * reset challangeStartTime when re-enabling the module Co-authored-by: almanax-ai[bot] <174396398+almanax-ai[bot]@users.noreply.github.com> * remove duplicated comment * test cleanup * fmt * semverlock * add livenessmodule2 to checkfrozenfiles * address alcueca's feedback * change ownershiptransfer logic * pre-pr * LivenessModule - Slightly simplified code (ethereum-optimism#17277) * Slightly simplified code --------- Co-authored-by: alcueca <alberto@yield.is> * address smartcontract's feedback * alcueca's feedback * smartcontract's feedback * add extra checks suggested by alcueca * fix clear error * update snapshots * conflicts * name nitpicks and coverage at 100% * fix tests * remove interface extra lines * fix event on test * rename isChallenged function to getChallengePeriodEnd * update snapshots * update implementation from specs * sentinel owner and interface fix * DRYness comments * move getter at the top * update comment * rename event * add _assertModuleConfigured * add _assertModuleEnabled * assert module enable fixes * _cancelChallenge internal function * fix comments * more comments * split configure errors * owner transfer invariant * address comments * address kelvin's feedback * lint * more comments * alcueca's comments --------- Co-authored-by: almanax-ai[bot] <174396398+almanax-ai[bot]@users.noreply.github.com> Co-authored-by: Alberto Cuesta Cañada <38806121+alcueca@users.noreply.github.com> Co-authored-by: alcueca <alberto@yield.is>
…thereum-optimism#17519) * op-acceptance-tests: move network presets into tests, away from config.yaml * op-acceptance-tests: simplify defaults for TestSyncTesterExtEL * op-acceptance-tests: add stack.ExtNetworkConfig
* feat: add U16a report * Update docs/security-reviews/README.md Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> --------- Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* fix(op-deployer): forge verbose install * fix(op-deployer): add ci docker build job
* opcm: Support cannon+kona games in addGameType * opcm: Update test name validation * opcm: Remove unnecessary skips. * opcm: Simplify test
…tests (ethereum-optimism#17510) * refactor(test-validation): extract exclusions to TOML config file - move hardcoded exclusion lists from Go code to external TOML configuration - add TOML parsing with structured ExclusionsConfig type - implement dynamic exclusions loading with fallback path resolution * test(test-validation): add test coverage for test-validation functions - add tests for all previously untested functions in main.go - organize test functions to match source file order
…imism#17542) * op-deployer: simplify ReadImplementationAddresses.s.sol * fix semgrep finding * use getEIP1967Impl helper function * fix comment
* Skip Interop Acceptance Tests * exempt TestSuperRootWithdrawal
…m#17514) As Isthmus is on Mainnet, we now move this gate into the 'base' gate which should work against all devnets.
…der (ethereum-optimism#17566) * txmgr: fetch BlobBaseFee over RPC instead of computing from block header This simplifies the transaction manager, meaning it does not need to understand the chain config of L1 in order to estimate fees properly (which, from Fusaka, it will otherwise need to do because the formula for computing the blob base fee from the excess blob gas changes frequently with BPO forks). * fix TestIncreaseGasPriceLimits * fix TestTxMgrConfirmsBlobTxAtHigherGasPrice * Update op-service/txmgr/txmgr.go Co-authored-by: Sebastian Stammler <seb@oplabs.co> --------- Co-authored-by: Sebastian Stammler <seb@oplabs.co>
…reum-optimism#17532) * op-devstack: Expose L2EthExtendedClient for shim L2EL * op-devstack: L2 CL Signaler Logic using admin API * op-acceptance-test: op-acceptance-tests: EL Sync Test Config * op-acceptance-tests: Sync Tester External Network HF tests: SyncMode * op-sync-tester: Fix Post Isthmus WithdrawalRoots check * op-devstack: Logging when L2 CL Signaling * op-devstack: Explict Read Only Ext L2EL * op-acceptance-tests: Proper preset for EL/CL Sync Testing * rebase and cleanup * ci: Sync Tester EL Sync test for real world * op-acceptance-tests: Proper genesis set for EL/CL Sync Testing * fix test name * deflake * tame possible race
0xDiscotech
commented
Sep 23, 2025
| "test/universal/ExtendedPause.t.sol", # Tests extended functionality | ||
| "test/vendor/Initializable.t.sol", # Tests external vendor code | ||
| "test/vendor/InitializableOZv5.t.sol", # Tests external vendor code | ||
| "test/L2/LegacyFeeSplitter.t.sol", # Tests legacy fee splitter with updated vaults interface |
Author
There was a problem hiding this comment.
Added by me while fixing conflict
0xDiscotech
commented
Sep 23, 2025
| "test/L2/GasPriceOracle.t.sol", # Contains contracts not matching GasPriceOracle base name | ||
| "test/universal/StandardBridge.t.sol", # Contains contracts not matching StandardBridge base name | ||
| "test/L1/OPContractsManagerContractsContainer.t.sol", # Contains contracts not matching OPContractsManagerContractsContainer base name | ||
| "test/L2/RevenueSharingIntegration.t.sol", # Contains contracts not matching RevenueSharingIntegration base name |
Author
There was a problem hiding this comment.
Added by me while fixing conflict
0xDiscotech
commented
Sep 23, 2025
Comment on lines
+45
to
+46
| UseRevenueShare: false, | ||
| ChainFeesRecipient: common.Address{}, |
Author
There was a problem hiding this comment.
Added by me while fixing conflict. This function was removed on the previous apply_test.go file
0xChin
approved these changes
Sep 23, 2025
agusduha
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.