Skip to content

ci: ensure velero task renovate datasource matches chart#2645

Merged
mjnagel merged 2 commits intomainfrom
mjnagel-patch-2
May 5, 2026
Merged

ci: ensure velero task renovate datasource matches chart#2645
mjnagel merged 2 commits intomainfrom
mjnagel-patch-2

Conversation

@mjnagel
Copy link
Copy Markdown
Contributor

@mjnagel mjnagel commented May 5, 2026

Description

Noted in #2635 and #2613 that Velero's chart is updating at a different cadence than the task (which controls CRDs).

This updates the renovate comment to use the identical datasource as the chart reference (helm) in order to ensure these should always update in the same PR.

@mjnagel mjnagel self-assigned this May 5, 2026
@mjnagel mjnagel requested a review from a team as a code owner May 5, 2026 19:00
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 5, 2026

Greptile Summary

This PR updates the Renovate annotation on VELERO_CRD_VERSION in src/velero/tasks.yaml from datasource=github-tags to datasource=helm, matching the datasource used for the Velero chart in common/zarf.yaml. This ensures future Renovate PRs bump both the chart version and the CRD task variable together.

  • Datasource alignment: switching from github-tags to helm with registryUrl=https://vmware-tanzu.github.io/helm-charts mirrors the chart definition exactly, so both values will be updated in the same Renovate PR going forward.
  • Residual version drift: tasks.yaml still defaults to 12.0.0 while common/zarf.yaml pins the chart at 12.0.1, meaning the update-crds task currently fetches CRDs from a stale tag — this pre-existing mismatch should be corrected alongside this change.

Confidence Score: 4/5

The datasource change is correct and achieves the stated goal, but the existing version mismatch between tasks.yaml (12.0.0) and common/zarf.yaml (12.0.1) means the update-crds task will pull wrong CRDs until the default is bumped.

The annotation itself is straightforward and well-reasoned, but the default version in tasks.yaml (12.0.0) still trails the deployed chart version (12.0.1) in common/zarf.yaml, leaving the CRD download task pointing at a stale chart tag.

src/velero/tasks.yaml — the VELERO_CRD_VERSION default needs to be bumped to 12.0.1 to match the chart

Important Files Changed

Filename Overview
src/velero/tasks.yaml Renovate datasource annotation for VELERO_CRD_VERSION updated from github-tags to helm to match the chart's datasource; the default version (12.0.0) still diverges from the chart version (12.0.1) in common/zarf.yaml

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Renovate Bot] -->|Before: datasource=github-tags| B[vmware-tanzu/helm-charts GitHub Tags]
    A -->|After: datasource=helm| C[vmware-tanzu Helm Registry]
    B -->|Updates VELERO_CRD_VERSION in tasks.yaml| D[tasks.yaml VELERO_CRD_VERSION]
    C -->|Updates VELERO_CRD_VERSION in tasks.yaml| D
    C -->|Also updates version in common/zarf.yaml| E[common/zarf.yaml chart version]
    D -->|Used to download CRDs from upstream| F[update-crds task]
    E -->|Deployed chart version| G[Velero Helm Chart Install]
    D -.->|Should match| E
    style B fill:#f88,stroke:#c44
    style C fill:#8f8,stroke:#4c4
Loading

Reviews (1): Last reviewed commit: "Update tasks.yaml" | Re-trigger Greptile

Comment thread src/velero/tasks.yaml
@mjnagel mjnagel merged commit ff075bd into main May 5, 2026
25 checks passed
@mjnagel mjnagel deleted the mjnagel-patch-2 branch May 5, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants