fix: handle v prefix in tags for test-upgrade#649
Merged
codyshoffner merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
Contributor
codyshoffner
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Packages that have previously used a
vprefix in their releases pull that version as the latest tag when settingLATEST_VERSIONfrom thezarf tools registrycommand, while theTAGenv variable intest-upgrade"Create test bundle of last tag" action correctly pulls the latest git tag that should be used for the Package. Adding asedreplacement in the command correctly handles the sorting when these tags are included, otherwise the latest tag with thevprefix always takes precedence over newer tags.Example of downstream Package pulling in the wrong version of the Package when checking out the correct git tag.
Example of that same downstream package successfully pulling the latest tagged Package using the
upgradetask file in the commit sha for this PR's commit.Checklist before merging