Skip to content

feat: added timeout override for zarf package deployments#1337

Merged
emoskito merged 3 commits intodefenseunicorns:mainfrom
JoshuaFurman:feat/package-timeout
Mar 5, 2026
Merged

feat: added timeout override for zarf package deployments#1337
emoskito merged 3 commits intodefenseunicorns:mainfrom
JoshuaFurman:feat/package-timeout

Conversation

@JoshuaFurman
Copy link
Copy Markdown
Contributor

Description

UDS doesn't currently expose the ability to override the deployment timeout of zarf packages in a UDS-bundle. This feature adds support to setting a timeout value override per zarf package in your uds-bundle.yaml file.

Related Issue

Fixes #588

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Misc

Following the contribution guidelines, I was unable to run the e2e test defined here: https://github.com/defenseunicorns/uds-cli/blob/main/CONTRIBUTING.md#running-tests as the test:e2e-no-ghcr-write task no longer exists but I ran all other automated tests and manual tests.

@JoshuaFurman JoshuaFurman requested a review from a team as a code owner March 3, 2026 18:45
@JoshuaFurman JoshuaFurman force-pushed the feat/package-timeout branch from acbde85 to 98d0e29 Compare March 3, 2026 19:04
Copy link
Copy Markdown
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small changes here - overall I think this makes sense. Would also be good to have a second review to sanity check.

Comment thread docs/reference/CLI/quickstart-and-usage.md Outdated
Comment thread src/pkg/bundle/deploy.go
Comment thread src/pkg/bundle/timeout.go Outdated
Comment thread src/pkg/bundle/timeout_test.go Outdated
Comment thread src/test/bundles/22-invalid-timeout/uds-bundle.yaml Outdated
Comment thread README.md Outdated
@JoshuaFurman JoshuaFurman force-pushed the feat/package-timeout branch from 98d0e29 to abcf081 Compare March 4, 2026 15:14
@JoshuaFurman
Copy link
Copy Markdown
Contributor Author

Resolved the copyright dates and timeout references in the docs. left timeout only in the relevant quickstart section.

didnt do anything with the validatePackageTimeouts() function since you requested additional review. Happy to pull it out if you think its unnecessary

@JoshuaFurman JoshuaFurman force-pushed the feat/package-timeout branch from 207c459 to 71ee140 Compare March 5, 2026 18:50
@emoskito emoskito requested a review from mjnagel March 5, 2026 18:52
@emoskito emoskito merged commit b3605f1 into defenseunicorns:main Mar 5, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support timeout as package parameter

3 participants