fix(registryinfo): set registry mode to empty by default#1330
Merged
Conversation
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
emoskito
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
uds-cli sets
RegistryInfo.RegistryModetonodeportby default. If a user is unaware of the explicit requirement to setINIT_REGISTRY_MODEtoexternalin the event they want to use an external registry - then this will fail even if url/creds are set appropriately.Zarf performs additional checks when
RegistryModeis an empty string to determine if it is internal or external. We should be able to remove this default assumption while still supporting those who want to set this explicitly.Slightly difficult to test - as you need an external registry that you can push to. I recently configured one locally but building this into the bug fix would take more time. We should file an additional issue for this testing infrastructure.
Related Issue
Fixes #1329
Type of change
Checklist before merging