feat(oci): report progress for OCI pull operations#1321
Merged
Conversation
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
mjnagel
reviewed
Feb 12, 2026
Contributor
There was a problem hiding this comment.
Maybe this was the case historically too, but with --no-progress the output is a bit weird:
• Pulling: uds-k3d-dev (0.00 Byte of 569.41 MBs)
✔ Successfully pulled: uds-k3d-dev (569.41 MBs)(this is running uds deploy k3d-core-slim-dev:latest --no-progress with a build of this branch)
LGTM overall though.
Edit: In thinking more about it, this seems like the best we can do probably if we want to adhere to no-progress. And I think this is a drop-in restoration of the old functionality so good with it.
mjnagel
approved these changes
Feb 12, 2026
Contributor
|
Approving - think we may want on merge until we get a separate patch out for the create/optional components bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
re-establishes parity with progress on OCI pull operations (bundle/packages) that existed prior to zarf removal of the message package.
Utils code was pulled from previous zarf releases before message package was removed and is generally copy/paste.
Visuals
Before:
After (in progress):
After (complete):
Related Issue
Fixes #1320
Relates to #
Type of change
Checklist before merging