[ds-inference] checkpoint loading => tqdm #2107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solve 2 issues: - less noise using tqdm progress bar - more informative - tell users how much to wait and how many shards to load New way: ``` Loading 72 checkpoints: 12%|█▎ | 9/72 [01:12<08:39, 8.25s/it] ```
stas00
commented
Jul 19, 2022
Collaborator
Author
|
It's actually interesting to watch tqdm processing here - the first checkpoints are loaded really fast and then it starts slowing down and elongating the ETA as the IO gets saturated. Unrelated to this PR, but perhaps we can use a different approach to loading, so that the io per shard happens only once per node and not 8 or 16 times concurrently? mmap or something similar? It'd probably make the loading much much faster. 10min to load is quite slow. and of course we discussing making 2 additional branches with pre-sharded-per-TP-rank data, so each process loads only what it needs. But that requires a lot more work and coding to look up the right checkpoint branch. |
tjruwase
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve 2 issues:
New way:
@RezaYazdaniAminabadi, @jeffra