Wrong partition_id while copying fp32_params -> fp16 params in Z2 for MoE #2058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Here's the comparison with ZeRO disabled. |
jeffra
approved these changes
Jun 27, 2022
Collaborator
jeffra
left a comment
There was a problem hiding this comment.
Excellent catch @siddharth9820, we discussed offline the existing issue w. the offload code path as well. We discussed this as a follow up PR though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post the optimizer step, Z2 uses incorrect partition ids for copying updated fp-32 params to their fp-16 counterparts. This leads to only a fraction of the non-expert parameters being trained. For reference, I have the loss curves before and after the bug fix.
Base Model - 1.3B
Number of Experts - 8
Batch Size - 256
Machine - Azure A100 40GB
Number of GPUs - 8
Dataset - BookCorpus