Added retain_graph as a kwarg to the main engine backward function #1149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… this now supports multiple calls to backwards with multiple losses
jeffra
approved these changes
Sep 30, 2021
raghavthind2005
approved these changes
Apr 12, 2022
|
Can one of the admins verify this patch? |
Contributor
|
@buttercutter , I have resolved the merge conflict. @ncilfone, FYI and apologies for delay on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added retain_graph as a kwarg to the main engine backward function -- this allows deepspeed's backward call to support multiple calls to backward with multiple losses since retain_graph is needed for the first backward call.
Closes #329