Skip to content

[config] no param naming validation #653

@stas00

Description

@stas00

I have noticed that one could make a typo in the config file and DeepSpeed silently ignores it. e.g. I did:

    "gradient_clipp1ng": 1

and got no errors.

Not sure if it should validate the value as well, as float is expected, but I guess int is fine as it's just converted to float.

This lack of validation could lead to user errors which could be hard to notice.

Nothing urgent, but at some point it'd be good to tell the user if they added a config entry which is invalid.

Thank you.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions