fix: S3 upload silent skip when select projects out mimeType/filename by deepshekhardas · Pull Request #7 · deepshekhardas/payload

deepshekhardas · 2026-05-19T05:01:54Z

When a POST request uses ?select[…] to project mimeType/filename out of the response doc, the cloud-storage plugin silently skips uploading to S3.

Fix by falling back to req.file properties when data.filename/data.mimeType are undefined due to select projection. Also handle sizes fallback using payloadUploadSizes when data.sizes is missing.

Summary by cubic

Fixes silent S3 upload skips when ?select omits mimeType/filename by falling back to request file data. Also improves auth handling in plugin-mcp, lazy-loads drizzle-kit, and fixes localized status updates.

Bug Fixes
- plugin-cloud-storage: fall back to req.file.name/req.file.mimetype when data.filename/data.mimeType are missing; use payloadUploadSizes when data.sizes is absent to avoid skipped uploads under ?select.
- plugin-mcp: accept both payload-mcp-api-keys API-Key <key> and Bearer <key> authorization headers.
- drizzle: lazy-load drizzle-kit in postgres/sqlite to prevent production bundling; update rows when only localized _status changes so the latest version is retrieved.

^{Written for commit 4158225. Summary will update on new commits. Review in cubic}

The MCP endpoint was accepting only Bearer token but Payload convention uses 'payload-mcp-api-keys API-Key <key>' format. Now accepts both: - 'payload-mcp-api-keys API-Key <key>' (Payload convention) - 'Bearer <key>' (backwards compatible) This makes the plugin consistent with other Payload API-key surfaces. Fixes: payloadcms#16572

When using localizeStatus, the last version wasn't retrieved properly when publishing directly. This is because the version_updatedAt and version_createdAt weren't being set properly when publishing. The fix adds a check for localized status (_status) in locales to ensure main row data update happens even when only localized fields have changed. Fixes: payloadcms#16395

drizzle-kit/api was being required at module load time, causing it to be included in production bundle for OpenNext Cloudflare and other edge runtimes. This moves the require() inside the function so it's only loaded when actually needed (during migrations/schema push). Also fixes the same issue in postgres adapter. Fixes: payloadcms#16470

When a POST request uses ?select[…] to project mimeType/filename out of the response doc, the cloud-storage plugin silently skips uploading to S3. Fix by falling back to req.file properties when data.filename/data.mimeType are undefined due to select projection. Also handle sizes fallback using payloadUploadSizes when data.sizes is missing. Closes payloadcms#16670

cubic-dev-ai

3 issues found across 5 files

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/drizzle/src/postgres/requireDrizzleKit.ts">

<violation number="1" location="packages/drizzle/src/postgres/requireDrizzleKit.ts:4">
P0: Temporal dead zone error: `require` is accessed before its `const` declaration. `const { createRequire } = require('module')` runs before `const require = createRequire(import.meta.url)`, so `require` is still in the TDZ and will throw a ReferenceError at runtime.</violation>
</file>

<file name="packages/drizzle/src/sqlite/requireDrizzleKit.ts">

<violation number="1" location="packages/drizzle/src/sqlite/requireDrizzleKit.ts:4">
P0: `require` is used on line 4 before it's declared on line 5. In this ESM module (`"type": "module"`), `require` is not a global, and the `const` declaration on line 5 puts it in the temporal dead zone, causing a ReferenceError at runtime. The original code kept the `createRequire` import at the top level (ESM import) and only created the require function inside — that ordering is required because you need `createRequire` before you can create `require`.</violation>
</file>

<file name="packages/plugin-cloud-storage/src/utilities/getIncomingFiles.ts">

<violation number="1" location="packages/plugin-cloud-storage/src/utilities/getIncomingFiles.ts:39">
P2: The `data.sizes ?? payloadUploadSizes` fallback is ineffective: `payloadUploadSizes` entries are Buffers, so `resizedFileData?.mimeType` is always missing and resized files are never added.</violation>
</file>

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

cubic-dev-ai · 2026-05-19T05:04:50Z

-const require = createRequire(import.meta.url)
-
 export const requireDrizzleKit: RequireDrizzleKit = () => {
+  const { createRequire } = require('module')


P0: Temporal dead zone error: require is accessed before its const declaration. const { createRequire } = require('module') runs before const require = createRequire(import.meta.url), so require is still in the TDZ and will throw a ReferenceError at runtime.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/drizzle/src/postgres/requireDrizzleKit.ts, line 4: <comment>Temporal dead zone error: `require` is accessed before its `const` declaration. `const { createRequire } = require('module')` runs before `const require = createRequire(import.meta.url)`, so `require` is still in the TDZ and will throw a ReferenceError at runtime.</comment> <file context> @@ -1,10 +1,8 @@ -const require = createRequire(import.meta.url) - export const requireDrizzleKit: RequireDrizzleKit = () => { + const { createRequire } = require('module') + const require = createRequire(import.meta.url) const { </file context>

cubic-dev-ai · 2026-05-19T05:04:50Z

-const require = createRequire(import.meta.url)
-
 export const requireDrizzleKit: RequireDrizzleKit = () => {
+  const { createRequire } = require('module')


P0: require is used on line 4 before it's declared on line 5. In this ESM module ("type": "module"), require is not a global, and the const declaration on line 5 puts it in the temporal dead zone, causing a ReferenceError at runtime. The original code kept the createRequire import at the top level (ESM import) and only created the require function inside — that ordering is required because you need createRequire before you can create require.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/drizzle/src/sqlite/requireDrizzleKit.ts, line 4: <comment>`require` is used on line 4 before it's declared on line 5. In this ESM module (`"type": "module"`), `require` is not a global, and the `const` declaration on line 5 puts it in the temporal dead zone, causing a ReferenceError at runtime. The original code kept the `createRequire` import at the top level (ESM import) and only created the require function inside — that ordering is required because you need `createRequire` before you can create `require`.</comment> <file context> @@ -1,10 +1,8 @@ -const require = createRequire(import.meta.url) - export const requireDrizzleKit: RequireDrizzleKit = () => { + const { createRequire } = require('module') + const require = createRequire(import.meta.url) const { </file context>

cubic-dev-ai · 2026-05-19T05:04:50Z

-    if (data?.sizes) {
-      Object.entries(data.sizes).forEach(([key, resizedFileData]) => {
-        if (payloadUploadSizes?.[key] && resizedFileData.mimeType) {
+    const sizes = data?.sizes ?? payloadUploadSizes


P2: The data.sizes ?? payloadUploadSizes fallback is ineffective: payloadUploadSizes entries are Buffers, so resizedFileData?.mimeType is always missing and resized files are never added.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/plugin-cloud-storage/src/utilities/getIncomingFiles.ts, line 39: <comment>The `data.sizes ?? payloadUploadSizes` fallback is ineffective: `payloadUploadSizes` entries are Buffers, so `resizedFileData?.mimeType` is always missing and resized files are never added.</comment> <file context> @@ -21,21 +21,25 @@ export function getIncomingFiles({ - if (data?.sizes) { - Object.entries(data.sizes).forEach(([key, resizedFileData]) => { - if (payloadUploadSizes?.[key] && resizedFileData.mimeType) { + const sizes = data?.sizes ?? payloadUploadSizes + if (sizes) { + Object.entries(sizes).forEach(([key, resizedFileData]) => { </file context>

github-actions · 2026-05-19T05:15:15Z

Pull Request titles must follow the Conventional Commits specification and have valid scopes.

The subject "S3 upload silent skip when select projects out mimeType/filename" found in the pull request title "fix: S3 upload silent skip when select projects out mimeType/filename"
didn't match the configured pattern. Please ensure that the subject
doesn't start with an uppercase character.

feat(ui): add Button component
^    ^    ^
|    |    |__ Subject
|    |_______ Scope
|____________ Type

jhb-dev · 2026-05-20T07:12:10Z

Hi @deepshekhardas, thanks for creating this PR that would close the issue I opened.

However, I would recommend removing the unrelated MCP plugin and Drizzle changes to increase the likelihood that the team merges this PR. They are out of scope and belong to a new PR in my opinion.

Developer added 4 commits May 19, 2026 10:24

cubic-dev-ai Bot reviewed May 19, 2026

View reviewed changes

github-actions Bot added the created-by: Payload team label May 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: S3 upload silent skip when select projects out mimeType/filename#7

fix: S3 upload silent skip when select projects out mimeType/filename#7
deepshekhardas wants to merge 4 commits into
mainfrom
fix/16670-s3-select-projection

deepshekhardas commented May 19, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

cubic-dev-ai Bot May 19, 2026

Uh oh!

cubic-dev-ai Bot May 19, 2026

Uh oh!

cubic-dev-ai Bot May 19, 2026

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

jhb-dev commented May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

deepshekhardas commented May 19, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot May 19, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot May 19, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot May 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

jhb-dev commented May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

deepshekhardas commented May 19, 2026 •

edited by cubic-dev-ai Bot

Loading