feat(astra): add run_async to AstraEmbeddingRetriever#3016
Merged
davidsbatista merged 6 commits intodeepset-ai:mainfrom Mar 24, 2026
Merged
feat(astra): add run_async to AstraEmbeddingRetriever#3016davidsbatista merged 6 commits intodeepset-ai:mainfrom
davidsbatista merged 6 commits intodeepset-ai:mainfrom
Conversation
|
|
Contributor
|
@nehaaprasad thank you for this contribution! I did a few adjustments and added two more tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes #1387
Proposed Changes
Add run_async on AstraEmbeddingRetriever with the same inputs and outputs as run, using asyncio.to_thread so sync search does not block the event loop.
Add a unit test that mocks search and checks run_async.
How did you test it?
Notes for the reviewer